Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List navigation commands breaks notebook focus/selection #117792

Closed
rebornix opened this issue Feb 26, 2021 · 1 comment
Closed

List navigation commands breaks notebook focus/selection #117792

rebornix opened this issue Feb 26, 2021 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
February 2021

Comments

@rebornix
Copy link
Member

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

  1. Open endgame.github-issues
  2. Focus the first cell by mouse click
  3. Arrow down
  4. Delete
  5. Both the first cell and the second cells are deleted

This was introduced after starting to read selections/focus from List View directly to support multiple selections in notebook. However the default list view behavior is different from what we would expect in Notebook.

What happens when you press arrow down in the list view

  • Cell 0 is selected and focused
  • Arrow down
  • Cell 1 is now focused

That's it. Cell 0 is still selected and cell 1 is now the focused cell. This the behavior you would expect when you are navigating in the File Explorer but weird in Notebook.

Does this issue occur when all extensions are disabled?: Yes/No
@rebornix rebornix self-assigned this Feb 26, 2021
@rebornix rebornix added notebook bug Issue identified by VS Code Team member as probable bug labels Feb 26, 2021
@rebornix rebornix added this to the February 2021 milestone Feb 26, 2021
@rebornix rebornix added the important Issue identified as high-priority label Feb 26, 2021
@connor4312 connor4312 added the verified Verification succeeded label Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
3 participants
@rebornix @connor4312 and others