Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue line in the left of explorer icon in activity bar when mouse down. #122003

Closed
pixieaka opened this issue Apr 23, 2021 · 10 comments
Closed

Blue line in the left of explorer icon in activity bar when mouse down. #122003

pixieaka opened this issue Apr 23, 2021 · 10 comments
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities wont-fix workbench-views Workbench view issues
Milestone

Comments

@pixieaka
Copy link

  • VS Code Version: 1.56.0 insider - commit: 0310f02
  • OS Version: Windows 10 20h2

Steps to Reproduce:

@sandy081 I have noticed this blue line in the left when mouse down only in file icon and this doesn't shows in the other icons. (0310f02) - Ref: #118077 (comment)

image

Does this issue occur when all extensions are disabled?: Yes

@miguelsolorio
Copy link
Contributor

Yes, this is the focus state for the activity bar. If you tab into the activity bar you'll see this as well so this is by design.

@miguelsolorio miguelsolorio added the *as-designed Described behavior is as designed label Apr 23, 2021
@pixieaka
Copy link
Author

@misolori But it's only in first icon ( explorer icon )! The other icons doesn't have focus state.

@miguelsolorio
Copy link
Contributor

@pixieaka this happens on all icons:

CleanShot.2021-04-24.at.15.40.11.mp4

@pixieaka
Copy link
Author

@misolori This not working with me in all icons !

Animation

image

@miguelsolorio
Copy link
Contributor

@sandy081 assigning to you since it seems the active state does not appear until after you've had keyboard access, so looks like a bug in the activity bar:

Screen.Recording.2021-04-26.at.9.04.07.AM.mov

@miguelsolorio miguelsolorio reopened this Apr 26, 2021
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug and removed *as-designed Described behavior is as designed labels Apr 26, 2021
@pixieaka
Copy link
Author

@sandy081 After latest update all icons works fine, But Timeline still doesn't work.

image

@miguelsolorio
Copy link
Contributor

It seems like the behavior is inconsistent overall. Sometimes it show and other times it doesn't.

@sandy081 sandy081 added this to the May 2021 milestone Apr 28, 2021
@sandy081 sandy081 modified the milestones: May 2021, June 2021 Jun 3, 2021
@sandy081 sandy081 modified the milestones: June 2021, July 2021 Jul 1, 2021
@sandy081
Copy link
Member

Blue line is showed when the item is focused and I am not sure why the item is not set to focused on click. More strangely it only works for the first item.

@sandy081 sandy081 modified the milestones: July 2021, Backlog Jul 28, 2021
@sandy081 sandy081 added the help wanted Issues identified as good community contribution opportunities label Jul 28, 2021
@hi-ogawa
Copy link

hi-ogawa commented Aug 22, 2021

Hi everyone, I made a PR to address this issue.
I explained it in the PR comment, but what I found is that tabindex attribute is only enabled for the first activity bar item, which is the "file explorer" tab. Note that "tabindex" is necessary for li tag (which is used for activity bar item) to have the ability of :focus selector to match and get a correct styling.
Please let me know if the PR properly solves the issue (and, importantly, doesn't make a new bug).

@sandy081 sandy081 removed their assignment Dec 12, 2024
Copy link

We closed this issue because we don't plan to address it.

Thanks for your understanding, and happy coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2024
@sandy081 sandy081 added the workbench-views Workbench view issues label Dec 12, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities wont-fix workbench-views Workbench view issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants