Error from build task does not appear in problems pannel

[alexdima]

• I ran cmd+shift+B to run the build task
• observe how there are errors in the terminal output, but no errors appear in the problems panel

Kapture.2021-05-27.at.21.23.32.mp4

[alexr00]

@alexdima a few questions:

• Is this on linux or Mac?
• Did you have the file open when the error occurred and then you just closed it?

[alexdima]

@alexr00 This is on mac. Yes, I think I had the file opened and then I closed it. I often do Close All to clear up by tabs and then go through remaining errors to prepare the commit.

[alexr00]

I'm not able to repro still, but maybe it's platform specific. @alexdima can you turn on terminal logging (Terminal: Toggle Escape Sequence Logging) then share the output from the debug console when the issue occurs?

[alexdima]

@alexr00 Yes, this looks to be OS specific. It reproduces immediately on the mac by running the build and then closing a file with errors. It does not reproduce on Windows.

I'm not able to repro still, but maybe it's platform specific. @alexdima can you turn on terminal logging (Terminal: Toggle Escape Sequence Logging) then share the output from the debug console when the issue occurs?

Here is the output:

xterm.js: parsing data [16:26:10] 
xterm.js: parsing data Starting �[32mcompilation�[39m...
xterm.js: parsing data [16:26:11] �[31mError�[39m: /Users/alex/src/vscode/src/vs/editor/browser/widget/codeEditorWidget.ts(291,3): Type '3' is not assignable to type 'ModelData | null'.
xterm.js: parsing data [16:26:11] Finished �[32mcompilation�[39m with 1 errors after �[35m1072 ms�[39m

[alexr00]

@alexdima it could be an issue with file watching then. When a file is closed, tasks re-assesses the problems, but it sounds like that isn't happening. Can you set your log level to trace, try to repro, then share the Window logs?

[alexdima]

@alexr00 Now I tried again to reproduce on mac and had problems reproducing, until I realized what you wrote: "when a file is closed, tasks re-assesses the problems". I often use Close All and often end up closing multiple files even if they are not opened in the current tab.

With this in mind, I tried again and now I can repro even on Windows:

• create problem in fileA.ts
• open fileB.ts
• click Close All

In the recording, I run into another issue of some sort, where the error is not clickable and the error message is all garbled up 🤷‍♂️

[alexdima]

Nevermind the weird part of the recording, I cannot find clear steps to trigger that. Sorry about that!

[alexr00]

This is a very sad duplicate of #119824 and a side effect of the work around I added for showing problems for tasks when a file is closed (#61140). To truly solve these issues, we will need help from the markers service to let markers have an additional "source" property so we can finally tell the difference between problems that come from the typescript language server and problems that come from tasks. @sandy081 FYI for the markers service.

[sandy081]

cc @jrieken for markers service

[jrieken]

To truly solve these issues, we will need help from the markers service to let markers have an additional "source" property so we can finally tell the difference between problems that come from the typescript language server and problems that come from tasks. @sandy081 FYI for the markers service.

That's how owner is meant to be used - e.g all diagnostics are indexed by resource and owner. Tasks seems to re-use existing owners to cancel out (or be cancelled out) when same but different diagnostics come along. Maybe a better approach would some special diagnostics tag that allows to express that certain diagnostics are coming from a less trustworthy source and should be ignore in presence of a different source

[meganrogge]

/duplicate #119824

[vscodenpa]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!