-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Incorrect Colorization of Fenced Code Blocks Inside of Block Quotes #12822
Comments
I suppose that this issue is kind of related to #3746. I'm having the same problem right now with JS code blocks. |
@dcbrwn Yes, this is another manifestation of #3746 but triggered by different behavior In markdown, the fenced code block tokenizers for various programming languages can currently escape outside of the fenced code block if there is a syntax error in the block. In this example, the I'm planning to address the core problem of fenced code block breakout soon. |
@mjbvz, mine issue with JS, TS and alike is caused by template string quote introduced in es6 ("`"). Workaround for now is to stick code blocks to some text like this (added back-slashes to preserve "```"):
|
Original issue fixed by #14626 @dcbrwn I think the issue you identified has also been fixed: Please try out the latest insiders builds and let me know if this is not the case. |
Thanks so much guys for all the great work you do 🎉 |
Seem to work as expected 👍 |
For a markdown file like this:
The colorization is incorrect. Depending on what language is targeted, the colorization can break out of the code block entirely:
Here's what things should look like:
The problem is that that block quote opening
>
are included as part of the fenced code block content. This causes some language colorizers to freak-out and highlight the entire rest of the file.The text was updated successfully, but these errors were encountered: