-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions publish do not warn/error on invalid extensionDependencies #12907
Comments
Added a warning for invalid identifiers, but not for non-existing ones. |
@sandy081 I see the entry now marked in vscode Two questions about the expected behavior though:
|
Yes, it does not allow
VSCE will publish them as new extensions if does not exist. I am not showing any squiggles for non-existent packages. It is just for invalid identifiers. |
Ok, I'm still allowed to vsce publish an extension with errors for Reopening |
@mjbvz I see what you mean. Currently VSCE only validates extension names not extension dependencies. I meant this in my above comment. Sorry, I was not clear. Fix here is to show only squiggles for invalid extension dependencies. Created an issue in VSCE to validate extension dependencies while publishing - microsoft/vscode-vsce#227 Since you confirmed the squiggles, I am closing this as verified. |
Test: Install a set of extensions #12647
I published an extension without errors with the following extensionDependencies:
It published fine but when installed it only installs
Tyriar.lorem-ipsum
.The text was updated successfully, but these errors were encountered: