Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions publish do not warn/error on invalid extensionDependencies #12907

Closed
Tyriar opened this issue Sep 28, 2016 · 5 comments
Closed

Extensions publish do not warn/error on invalid extensionDependencies #12907

Tyriar opened this issue Sep 28, 2016 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2016

I published an extension without errors with the following extensionDependencies:

    "extensionDependencies": [
        "[email protected]",
        "Tyriar.lorem-ipsum"
    ]

It published fine but when installed it only installs Tyriar.lorem-ipsum.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Sep 28, 2016
@joaomoreno joaomoreno removed their assignment Sep 28, 2016
@sandy081 sandy081 added this to the October 2016 milestone Sep 28, 2016
@sandy081 sandy081 modified the milestones: November 2016, October 2016 Oct 26, 2016
@sandy081 sandy081 modified the milestones: Backlog, November 2016 Dec 7, 2016
@sandy081
Copy link
Member

sandy081 commented Nov 20, 2017

Added a warning for invalid identifiers, but not for non-existing ones.

@sandy081 sandy081 modified the milestones: Backlog, November 2017 Nov 20, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 5, 2017

@sandy081 I see the entry now marked in vscode

screen shot 2017-12-05 at 2 28 15 pm

Two questions about the expected behavior though:

  • Should "[email protected]" generate warnings or errors when you run vsce publish on the command line?
  • Should entries for non-existant packages such as "nonsuch.package" generate errors?

@sandy081
Copy link
Member

sandy081 commented Dec 7, 2017

@mjbvz

Should "[email protected]" generate warnings or errors when you run vsce publish on the command line?

Yes, it does not allow

Should entries for non-existant packages such as "nonsuch.package" generate errors?

VSCE will publish them as new extensions if does not exist. I am not showing any squiggles for non-existent packages. It is just for invalid identifiers.

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 7, 2017

Ok, I'm still allowed to vsce publish an extension with errors for "[email protected]" using vsce 1.35.0

Reopening

@sandy081
Copy link
Member

sandy081 commented Dec 8, 2017

@mjbvz I see what you mean. Currently VSCE only validates extension names not extension dependencies. I meant this in my above comment. Sorry, I was not clear.

Fix here is to show only squiggles for invalid extension dependencies.

Created an issue in VSCE to validate extension dependencies while publishing - microsoft/vscode-vsce#227

Since you confirmed the squiggles, I am closing this as verified.

@sandy081 sandy081 closed this as completed Dec 8, 2017
@sandy081 sandy081 added verified Verification succeeded and removed verification-found Issue verification failed labels Dec 8, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants