Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook gets stuck after deleting and undoing a cell while running #133782

Closed
DavidKutu opened this issue Sep 24, 2021 · 5 comments
Closed

Notebook gets stuck after deleting and undoing a cell while running #133782

DavidKutu opened this issue Sep 24, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@DavidKutu
Copy link

DavidKutu commented Sep 24, 2021

Does this issue occur when all extensions are disabled?: No

  • Version: 1.61.0-insider (user setup)
  • Commit: 8d30d4d
  • Date: 2021-09-24T09:00:59.405Z
  • Electron: 13.4.0
  • Chrome: 91.0.4472.164
  • Node.js: 14.16.0
  • V8: 9.1.269.39-electron.0
  • OS: Windows_NT x64 10.0.19043

Steps to Reproduce:

  1. Run a cell
  2. Delete it while its running
  3. press ctrl+z
  4. when the cell comes back, it thinks its still running and it can't be interrupted, even if the extension restarts or interrupts the kernel
    proof
@roblourens
Copy link
Member

Were you working on this last week @DavidKutu, is there anything we want to do for September?

@DavidKutu
Copy link
Author

I just handled the debug session on the extension, but this still happens with the editor on VS Code's side.

@roblourens
Copy link
Member

This is part of #125668 basically

@roblourens
Copy link
Member

Is now fixed in #125668

@IanMatthewHuff IanMatthewHuff added the verified Verification succeeded label Jan 27, 2022
@IanMatthewHuff
Copy link
Member

Looks good to me. In the log I can see an error when the cell is deleted but it's an error for a cancelled future when waiting for replies which seems appropriate for this situation.

After cmd+z the cell is back in a ready to execute state and the cell can be run.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants