TS 4.5.0-dev.20211029: JSX attrbutes not showing in intellisense

[markusjohnsson]

Bug Report

🔎 Search Terms

jsx tsx props attributes intellisense not working after newline

🕗 Version & Regression Information

• This changed between versions 4.4.4 and 4.5.0-dev.20211029

⏯ Playground Link

Sorry, cannot use JSX in playground.

💻 Code

function MyComponent({ a, b }: { a: number; b: string; }) {
    return <div/>;
}

function Foo() {
    return <div>
        <MyComponent
                  (invoke intellisense here)
        />
    </div>
}

🙁 Actual behavior

In 4.5.0-dev.20211029, JSX/TSX props/attributes are not displayed in intellisense completion after a newline.

same line works:

after newline, does not work:

🙂 Expected behavior

JSX/TSX props/attributes

4.4.4:
both works:

[a-tarasyuk]

I checked the provided example and it looks like the completion works Playground. Are there any additional steps to reproduce this issue?

/cc @andrewbranch

[DanielRosenwasser]

It repros locally on an insiders VS Code, so I assume that when an editor supports snippet completions (the playground doesn't AFAIK) then we're doing something wrong.

[andrewbranch]

Ah indeed, this looks like a VS Code bug. I can repro in VS Code, but the TS Server log looks as expected:

{
  "seq": 0,
  "type": "response",
  "command": "completionInfo",
  "request_seq": 231,
  "success": true,
  "body": {
    "isGlobalCompletion": false,
    "isMemberCompletion": true,
    "isNewIdentifierLocation": false,
    "entries": [
      {
        "name": "a",
        "kind": "JSX attribute",
        "kindModifiers": "",
        "sortText": "11",
        "insertText": "a={$1}",
        "replacementSpan": {
          "start": {
            "line": 11,
            "offset": 7
          },
          "end": {
            "line": 11,
            "offset": 8
          }
        },
        "isSnippet": true
      },
      {
        "name": "b",
        "kind": "JSX attribute",
        "kindModifiers": "",
        "sortText": "11",
        "insertText": "b=\"$1\"",
        "replacementSpan": {
          "start": {
            "line": 11,
            "offset": 7
          },
          "end": {
            "line": 11,
            "offset": 8
          }
        },
        "isSnippet": true
      },
      {
        "name": "key",
        "kind": "JSX attribute",
        "kindModifiers": "declare,optional",
        "sortText": "12",
        "insertText": "key={$1}",
        "replacementSpan": {
          "start": {
            "line": 11,
            "offset": 7
          },
          "end": {
            "line": 11,
            "offset": 8
          }
        },
        "isSnippet": true
      }
    ]
  }
}

[DanielRosenwasser]

Nice, I'll defer to Andrew's investigation - @mjbvz can you transfer this to the VS Code side? I don't have permissions to do so.

[markusjohnsson]

I've pushed my repro here: https://github.com/markusjohnsson/ts-46576

[andrewbranch]

Just verified that our response on a single-line and on the split-line locations looks basically identical, so yeah, I think VS Code is just incorrectly filtering these out for some reason?

[typescript-bot]

This issue has been marked as 'External' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

[markusjohnsson]

Was this ever transferred to the vscode tracker?

[andrewbranch]

@markusjohnsson thanks for the reminder ☝️

[mjbvz]

@andrewbranch I believe the root cause is that ts now returns a replacementSpan in this example:

  "insertText": "b=\"$1\"",
            "replacementSpan": {
                "start": {
                    "line": 9,
                    "offset": 9
                },
                "end": {
                    "line": 9,
                    "offset": 10
                }
            },

Do you know why this span is being returned? It seems to map to the closing / in /> which seems incorrect

We probably need to fix this for November VS Code release (start of December)

[andrewbranch]

@mjbvz the fix for this is in the 4.5 branch now 👍

[mjbvz]

Thanks @andrewbranch! Closing as fixed upstream