Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom styled tooltips everywhere #136575

Closed
letmaik opened this issue Nov 6, 2021 · 10 comments
Closed

Use custom styled tooltips everywhere #136575

letmaik opened this issue Nov 6, 2021 · 10 comments
Assignees
Labels
polish Cleanup and polish issue ux User experience issues

Comments

@letmaik
Copy link
Member

letmaik commented Nov 6, 2021

There is an awkward mix of native and custom styled tooltips currently. Some examples from Windows:

image

image

image

image

image

If window zoom is used (as above), then the mix is most apparent, since native tooltips don't zoom.

I think it would be best if all tooltips would use custom styling to make things consistent and more accessible.

@alexdima alexdima assigned Tyriar and unassigned alexdima Nov 9, 2021
@Tyriar Tyriar added polish Cleanup and polish issue ux User experience issues labels Nov 9, 2021
@Tyriar
Copy link
Member

Tyriar commented Nov 9, 2021

There are also some users who hate the custom hover and think everything should be native. Unfortunately because of how differently they're used (a function on hover vs title attr which must be there on hover) it's difficult to have a setting to drive this.

@miguelsolorio
Copy link
Contributor

I personally would prefer to switch all to custom tooltips, but I think also in the past we've talked about the perf hit that this could introduce.

@Tyriar
Copy link
Member

Tyriar commented Nov 9, 2021

Probably wouldn't impact performance as hovers can be evaluated lazily with the custom hover.

@keenbowl3009
Copy link

The problem with "native hovers" vs "custom hovers" lies simply in the ability to show things outside of the vscode window borders.

The only reason why people keep this option still turned on is because of that limitation.

@keenbowl3009
Copy link

There are also some users who hate the custom hover and think everything should be native.

Because the native parts can be shown outside of the vscode window when vscode is not maximized.

@Tyriar
Copy link
Member

Tyriar commented Nov 12, 2021

@keenbowl3009 I don't think that's the only reason, some people are just fundamentally opposed to the window looking different to the OS. Same reason people use the native title bar when the custom one is superior at this point.

@JennyStig
Copy link

@keenbowl3009 I don't think that's the only reason, some people are just fundamentally opposed to the window looking different to the OS. Same reason people use the native title bar when the custom one is superior at this point.

The custom title bar is not superior, because it cannot be shown outside the window borders.

The only reason why people use the custom title bar is because it's a default setting, and has been like that for a long time.
You know it, I know it, and everyone who has worked on vscode knows it.

Pretending otherwise imho is a cynical act.

@Tyriar
Copy link
Member

Tyriar commented Nov 15, 2021

Here's that issue I alluded to above where people want to disable the custom hovers: #134203

@letmaik
Copy link
Member Author

letmaik commented Nov 15, 2021

I'm going to close this, I realized this is way less important than dealing with the frequency/occurence of tooltips (#15667) which is something that trips me up way more than styling inconsistencies. If people feel strongly about styling, then please keep up/down-voting the first post in this issue and maybe at some point it can be addressed one way or another.

@letmaik letmaik closed this as completed Nov 15, 2021
@ShanConn
Copy link

I hate these custom hovers and those tooltips. On top of that, they are all inconsistently placed, they are extremely distracting, and they don't work with the native titlebar on windows.

Each day vscode is getting more privacy invasive and unpleasant to use, making developers more and more unproductive and implementing addictive social networking UI patterns.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue ux User experience issues
Projects
None yet
Development

No branches or pull requests

7 participants