Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ungrouped settings in the Settings editor extensions ToC #137259

Closed
rzhao271 opened this issue Nov 15, 2021 · 1 comment
Closed

Allow ungrouped settings in the Settings editor extensions ToC #137259

rzhao271 opened this issue Nov 15, 2021 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@rzhao271
Copy link
Contributor

See #126089 (comment)

An idea is that if the category title is the same as the main extension title, then the settings should just be in a group under the main extension heading itself in the Settings editor.

@rzhao271 rzhao271 added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Nov 15, 2021
@rzhao271 rzhao271 added this to the November 2021 milestone Nov 15, 2021
@rzhao271 rzhao271 self-assigned this Nov 15, 2021
@rzhao271 rzhao271 changed the title Allow extension heading itself in Settings editor to carry settings Allow ungrouped settings in the Settings editor extensions ToC Nov 16, 2021
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Nov 16, 2021
@rzhao271
Copy link
Contributor Author

Verification steps:

  1. Clone, build, and run the following extension https://github.com/rzhao271/settings-editor-tocsort.
  2. Open the Settings editor and look at the "Extensions" section of the table of contents (extensions ToC).

What we want:

  1. There should be an entry called "Z extension" near the bottom of the list of extensions.
  2. That extension should have three categories in the order A, B, and C.
  3. One should be able to click on the "Z extension" entry itself. That action results in the Settings editor focusing on the heading "Z extension", and there should be settings J, K, and L right under that heading. After those settings, there should be a subheading for the A category.

Also see #137257 as that issue has very similar verification steps.

@tanhakabir tanhakabir added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@rzhao271 @tanhakabir and others