Suggestion: show the number of matches when running a search

[rickmed]

No description provided.

[bpasero]

@ricmed205 can you clarify what you want?

[rickmed]

Yes! I wast just editing. Sorry.
When using the find in file feature (ctrl+f), show the number of matches when running a search.

[bpasero]

Ok thanks.

[bpasero]

@alexandrudima fyi

[rhbecker]

+1

... and along those same lines, it would be useful to see the "index" of the currently highlighted match; e.g. if there are 20 matches and the 14th is highlighted, I'd see 14/20, and find next / find previous would increment / decrement the index, respectively.

[alexdima]

@rhbecker I've just pushed a few days ago a match counter, but it doesn't show at this time X of Y, it just shows Y:

[stevencl]

I would consider putting the label x of y next to the next and previous arrows rather than next to the search options. For example (without and with a border around the x of y label below)

Just to check though, what is the UX problem that we are trying to solve with this? Is it that without this, the user is unaware when they have reviewed all of the search results? Or is this solving another UX problem? That could help determine how important it is to show an x of y label.

How should search results be indexed? I think I would expect, if I wanted to be aware when I have reviewed all of the search results, that the result labeled 1 of y should be the first result found after the current insertion point, rather than the first item in the file.

[alexdima]

@stevencl Wow that looks so much better and makes a lot of sense to put them next to the prev/next buttons 👍

How should the replace buttons be aligned then?:

I personally would expect them to be always indexed from the top and then you'd start at "5 of 14" if that would be the next match. That is what Chrome's find does for example.

I am not sure what the underlying UX problem is, we have always been asked to show some numbers in there. Maybe @chrisdias and @ricmed205 can add more details.

[stevencl]

Starting at 5 of 14 would work too I think, that sounds good.
I would continue to align the replace buttons next to the right edge of the replace text box. Fortuitously, this also means that the replace button sits underneath the index and the replace all button sits underneath the count :-).

[rickmed]

"5 of 50" just like Chrome is perfect -where the index starts at the top of the doc.

@stevencl 👍 UX
" Is it that without this, the user is unaware when they have reviewed all of the search results?" <- This

[rhbecker]

@alexandrudima

Your responsiveness to our suggestions is very much appreciated!

@stevencl

what is the UX problem that we are trying to solve with this?

In addition to what's already been stated ...

I find y useful in determining whether to add more detail to my query.

I type "dog" on my way to "doggy". I'm lazy, so as soon as typing "dog" gets me to a small y, I'll start tabbing through results. Maybe I was inconsistent in my usage of the "gy" suffix, and it's handy to see that some of my matches are like "dogYears". But maybe "dog" didn't get my y small enough, because someone else used "doge" like 40 times, so I'll keep typing to distinguish, in order to get y smaller - to a quantity that's easier to deal with.

I find x useful as a wayfinding mechanism.

I'm the sort of person who gets confused if I'm not starting at either the beginning or end of a document. If I start in the middle, I'll forget where in the middle, and won't know when I've arrived back at where I started. If I run a search and my x is closer to 1 than y, I'll scroll backward to get to 1 before I start dealing with my matches, while if my x is closer to y, I'll scroll forward to get to y (or will go one more "forward" to circle back to 1) before I start dealing with my matches.

The matches visualization in the scroll bar is nice, but it's also a bit ambiguous. I can't always tell at a glance whether I'm really on the first or last match. Certainly, it doesn't help me know I'm on the 34th match.

If I'm reviewing / discussing a document with someone else, it's handy to say "go to the 8th match".

[alexdima]

Had some time today to work on this. Given the UX sketch, here's what I could come up with:

A. variable width widget

B. fixed width widget, variable width label

C. fixed width widget, fixed width label

My personal favorite is C, since in A and B things float around, which draws attention for no good reason and it feels wierd.

@stevencl Thoughts?

[stevencl]

C looks good I think.

Nice work!

[chrisdias]

👍

[rickmed]

@alexandrudima awesome.

Have you tried tried placing the "X of X" inside the label (on the right part), replacing it with caps and regex options? the whole thing would be fixed width

Similar to chrome

[stereokai]

+1 for C. At least until someone comes up with something aesthetically superior - because the quirky jumpiness of A and B is distractive and impairs the user experience. Great work @alexandrudima 👍