Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all Symbols: Partial matching is not supported #148833

Closed
liyuhang1997 opened this issue May 5, 2022 · 4 comments · Fixed by #148912
Closed

Show all Symbols: Partial matching is not supported #148833

liyuhang1997 opened this issue May 5, 2022 · 4 comments · Fixed by #148912
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken verified Verification succeeded workspace-symbols
Milestone
May 2022

Comments

@liyuhang1997
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.67.0 Stable
  • OS Version: Windows 11

Steps to Reproduce:

  1. Create a .md file, add a header # test test
  2. Try ⌘T, type est
  3. 1.66.2: works fine
    屏幕截图 2022-05-06 025700
  4. 1.67.0: No matching workspaces symbols
    屏幕截图 2022-05-06 025820
@mjbvz
Copy link
Collaborator

mjbvz commented May 5, 2022

@jrieken I confirmed that markdown returns the workspace symbols in this case. They then seem to be filtered out on the VS Code side

@liyuhang1997

This comment was marked as off-topic.

Sign in to view
@jrieken
Copy link
Member

jrieken commented May 6, 2022

@TylerLeonhardt @bpasero Did the filtering for quick pick change?

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label May 6, 2022
@jrieken jrieken added regression Something that used to work is now broken workspace-symbols labels May 6, 2022
@jrieken
Copy link
Member

jrieken commented May 6, 2022

This is a regression from 368c39c. I have changed how fuzzyScore is configured and made the wrong adoption here...

@jrieken jrieken added this to the May 2022 milestone May 6, 2022
@jrieken jrieken mentioned this issue May 6, 2022
Merged
@raulvaldoleiros raulvaldoleiros mentioned this issue May 11, 2022
Closed
@aeschli aeschli added the verified Verification succeeded label May 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken verified Verification succeeded workspace-symbols
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

invoke fuzzyScore with the options to allow first match to be weak microsoft/vscode
5 participants
@jrieken @aeschli @mjbvz @liyuhang1997 and others