errors thrown by openerService.resolveExternalUri not surfaced to MainThreadWindow.$asExternalUri in VS Code Web

[jsjoeio]

• VS Code Version: 1.72.1 (main)
• OS Version: N/A
• Browser: Chrome

Steps to Reproduce:

1. git clone https://github.com/microsoft/vscode.git
2. run VS Code Web locally
3. install any extension that uses asExternalUri (i.e. this one)
4. run command "Hello World"
5. Open Browser Console

Expected
Should log error thrown 'Could not resolve external URI: ' + resource.toString()

Actual
Nothing

Notes
I believe this happens because there is no try/catch block here:
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/api/browser/mainThreadWindow.ts#L63

When you add a try/catch block there like so:

		try {
			const result = await this.openerService.resolveExternalUri(URI.revive(uriComponents), options);
			return result.resolved;
		} catch (e) {
			console.error('something wrong', e);
		}
		const result = await this.openerService.resolveExternalUri(URI.revive(uriComponents), options);
		return result.resolved;

Then it logs the thrown error

Screenshot

Would you accept a PR to fix this?

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[jsjoeio]

Oops, I put the wrong version. This is off main so it's the latest. Updated issue description.

[mjbvz]

I don't think logging there is correct. Instead extensions should get an exception if asExternalUri throws

Looks like we sort of already do this but not for http uris:

vscode/src/vs/workbench/api/common/extHost.api.impl.ts

Line 361 in fa758a7

if (matchesScheme(uri, Schemas.http) || matchesScheme(uri, Schemas.https)) {

@joaomoreno The history oI this code is kind of messy but I believe these checks were first added in a6f7aa5

Do you remember why exceptions are ignored for http uris?

[joaomoreno]

Sorry for the long delay replying.

I don't really remember, other than this being very specific to how URL callbacks are used in vscode.dev/github.dev. Check this one out: f99e1c3