Dirty indicator shows after some delay when restoring from backup

[jrieken]

re #16544

• exit VS Code with an untitled (large) file
• restart VS Code
• 🐛 the untitled is retired and only after a large delay it is marked as dirty

[bpasero]

@jrieken in that animation, was large.txt actually dirty? or are you saying the dirty decoration for Untitled-1 kicks in late?

[jrieken]

Yes - Untitled-1 is late by ~1sec

[bpasero]

I wonder if we could just store the dirty decoration as some view state and bring it back even before we look at the backups.

[Tyriar]

@bpasero at what point would the dirty indicator be invalidated if the backup no longer exists?

[bpasero]

Yeah it is tricky, needs more thought. The code that currently revives a backup could also act when a tab thinks it has a backup when in fact it does not.

[bpasero]

Also when you have many dirty files, it takes a long time until all backups are restored. This can easily be seen when doing a large find & replace operation without saving and then restarting.

[Tyriar]

The delay appears to be quite small for me now.