Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve aliases before checking for terminal quick fixes #166501

Closed
meganrogge opened this issue Nov 16, 2022 · 2 comments
Closed

resolve aliases before checking for terminal quick fixes #166501

meganrogge opened this issue Nov 16, 2022 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
feature-request Request for new features or functionality terminal-shell-integration Shell integration infrastructure, command decorations, etc.
Milestone
On Deck

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Nov 16, 2022 •
edited
Loading

We could read all the aliases in our shell integration scripts and send that to VS Code

For all selectors that include a commandMatcher, we could resolve the aliases of the commandLine before running the match
@meganrogge meganrogge added this to the November 2022 milestone Nov 16, 2022
@meganrogge meganrogge added feature-request Request for new features or functionality terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Nov 16, 2022
@meganrogge
Copy link
Contributor Author

work started here fbf71d8

ran into an issue w zsh where the alias string was too long to send via a command

@meganrogge meganrogge mentioned this issue Nov 18, 2022
Merged
@Tyriar Tyriar modified the milestones: December 2022, On Deck Nov 28, 2022
@meganrogge meganrogge mentioned this issue Nov 29, 2022
Closed
@meganrogge meganrogge mentioned this issue Feb 22, 2023
Closed
@meganrogge
Copy link
Contributor Author

I haven't seen any requests for this, so closing.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality terminal-shell-integration Shell integration infrastructure, command decorations, etc.
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge