Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] python repl content is not parsable in the a11y terminal buffer when Powershell is used #174797

Closed
jooyoungseo opened this issue Feb 19, 2023 · 5 comments
Assignees
Labels
terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@jooyoungseo
Copy link

CC @meganrogge

  • Note: the following issue is not found with cmd Command Prompt terminal profile. I suspect there is something that has to do with integrated shell.

Reproducible Steps

  1. Load NVDA.

  2. Run Terminal: Create New Terminal (With Profile).

  3. Choose terminal-powershell

  4. In Powershell, type python to open python repl.

  5. Type the following in python shell and hit enter:

1+2
  1. See if you can read ipython content in a11y terminal buffer.

Current Behavior

No terminal content available for this session. Run some commands to create content.

Expected Behavior

python content should be accessible in the terminal buffer.

System Info

Version: 1.76.0-insider (system setup)
Commit: 96a795c
Date: 2023-02-17T22:22:55.538Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

@meganrogge
Copy link
Contributor

This one's tricky because we don't trap the output of sub-shells ATM. Perhaps we should have a setting that lets the user decide whether or not we show the full contents of the buffer vs the shell integration contents

@meganrogge meganrogge added under-discussion Issue is under discussion for relevance, priority, approach terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode labels Feb 21, 2023
@meganrogge meganrogge added this to the March 2023 milestone Feb 21, 2023
@jooyoungseo
Copy link
Author

Yes, having that user setting would minimize this confusion.

@meganrogge
Copy link
Contributor

As we've discussed the other way to work around this is by disabling shell integration. Perhaps we should just present the whole buffer when a screen reader is detected?

Do you think it would be useful to have cwd, the command, and output via shell integration or should we just provide the whole buffer @jooyoungseo ?

there's also the idea of using symbols / an outline view eventually #174079

@jooyoungseo
Copy link
Author

@meganrogge -- Yes, the whole output would be preferred. I have detailed some more ideas about the terminal symbol providers in my response to #174079.

@meganrogge
Copy link
Contributor

We are planning to present all of the contents of the terminal buffer going forward, so this won't be an issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
terminal-accessibility Issues related to the terminal help widget, accessibility buffer, or navigation mode under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @jooyoungseo @meganrogge and others