Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow key navigation always targets editor scroll position #177800

Closed
chrmarti opened this issue Mar 21, 2023 · 3 comments · Fixed by #192472
Closed

Arrow key navigation always targets editor scroll position #177800

chrmarti opened this issue Mar 21, 2023 · 3 comments · Fixed by #192472
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@chrmarti
Copy link
Collaborator

Testing #177719

Up / down, go to top / bottom always targets the editor's scroll position, not the cell's scroll position. (Related: #177792)

@chrmarti
Copy link
Collaborator Author

It actually only navigates the input cells. I can then tab into the input cell, but not the output cell.

I think for accessibility there would have to be a way to focus the output cell, so that can be scrolled too?

@Tyriar
Copy link
Member

Tyriar commented Mar 21, 2023

I also see this, page up/down, ctrl+home/end act strangely

@rebornix
Copy link
Member

We didn't update when clauses for arrow keys and page down/ups so when the focus is inside the scrollable output, it scrolls both the output and the editor.

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-builtin-renderers labels Mar 21, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Sep 7, 2023
@vscodenpa vscodenpa added this to the September 2023 milestone Sep 7, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 8, 2023
@bhavyaus bhavyaus added the verified Verification succeeded label Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants