Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Notebook Toolbar rewrite #186261

Closed
2 tasks done
Yoyokrazy opened this issue Jun 27, 2023 · 1 comment
Closed
2 tasks done

Test: Notebook Toolbar rewrite #186261

Yoyokrazy opened this issue Jun 27, 2023 · 1 comment

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Jun 27, 2023

Refs: #161119

Complexity: 2

Create Issue


Summary:

The notebook toolbar was refactored to adopt the Workbench toolbar, allowing users to hide certain actions as they want.

Steps to Test:

  • Open a notebook, and select a kernel, populating all of the actions in the toolbar
  • Test the following for the three settings: (notebook.globalToolbarShowLabel with always/never/dynamic)
    • Resize your window and ensure that actions overflow into the secondary menu properly.
    • Resize your window and ensure there is never a separator between an action and the secondary menu.
    • Hide actions and ensure they end up in the overflow menu inside their own divided section
      • The secondary menu should have three sections: (top) Hidden | Overflow | Secondary (bottom), see screenshot for example
    • Hide all actions between two separators, ensure that only one separator is now rendering.
    • Hide all actions before the first separator, ensuring the separator is hidden as well once there are none left preceding it.
    • Hide all actions after the last separator, ensuring the separator is hidden as well once none follow it

image
*restart is the hidden action here


Thanks so much for testing!

@vscodenpa vscodenpa added this to the June 2023 milestone Jun 27, 2023
@ghost ghost assigned bhavyaus and aiday-mar Jun 27, 2023
@aiday-mar
Copy link
Contributor

Hi @Yoyokrazy! Great work. I was testing point 3 in the list and I see only two sections, the menu appears to be containing the same commands, but the restart command is not separated from the rest of the commands as in the screenshot. I am wondering if this is expected?

Screenshot 2023-06-27 at 14 28 00

@aiday-mar aiday-mar removed their assignment Jun 27, 2023
@bhavyaus bhavyaus removed their assignment Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants