Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the history of find and replace strings #18735

Closed
thekalinga opened this issue Jan 18, 2017 · 9 comments
Closed

Keep the history of find and replace strings #18735

thekalinga opened this issue Jan 18, 2017 · 9 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search-replace Search and replace issues
Milestone

Comments

@thekalinga
Copy link

  • VSCode Version:

Version 1.9.0-insider
Commit 39d761b
Date 2017-01-18T07:21:35.814Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0

  • OS Version:

Ubuntu 14.04

Steps to Reproduce:

  1. Open any file, Enter find and replace strings
  2. Close find & replace dialog & then close file
  3. Open the same file. Click any word in the file & press ctrl+f. Your earlier search string is gone. You need to retype the whole search string & replace strings.

Like notepad++, you should have the ability to select previous search strings & replace strings. Otherwise, all complex regex you write for both search & replace strings are screwed as soon as you click in the wrong area and open the find dialog.

Currently up & down arrow move the cursor to the start & end of the search string, but they should be mapped to navigate search/replace string history

@thekalinga
Copy link
Author

thekalinga commented Jan 18, 2017

Also, ctrl+z does not work properly with in search string field, in the above scenario aswell.

If the editor automatically replaces the search string with the word under cursor, ctrl+z behaviour is wierd & messes up the whole search string

@dbaeumer dbaeumer added the search Search widget and operation issues label Jan 19, 2017
@roblourens
Copy link
Member

You can use alt+up/down to navigate the search string history and get back the replaced one.

@thekalinga
Copy link
Author

Thanks for that.

This comment is still valid

Also, ctrl+z does not work properly with in search string field, in the above scenario aswell.

If the editor automatically replaces the search string with the word under cursor, ctrl+z behaviour is weird & messes up the whole search string

@thekalinga
Copy link
Author

Also, alt+up, alt+down does not work for replace string input box, this works only for search input box

@smuuf
Copy link

smuuf commented Jul 28, 2017

I usually have some complex wildcards in "files to include" and/or "files to exclude" fields and it's very annoying that these fields don't have some sort of history, too. 😭

@sandy081
Copy link
Member

@smuuf We recently implemented history navigation for files to include and files to exclude fields. Please check it out in latest stable or insiders.

Only field to be supported is replace.

@smuuf
Copy link

smuuf commented Aug 31, 2017

@sandy081 Yes, I believe that in the latest stable 1.15.1 the files to include/exclude fields do really have a history. Using alt+up/down while having focus in those fields lets the user to browse its history.

Which is really cool. :) Thank you, guys.

@sandy081 sandy081 added search-replace Search and replace issues and removed search Search widget and operation issues labels Dec 4, 2017
@sandy081
Copy link
Member

sandy081 commented Dec 4, 2017

Duplicate of #18233

@sandy081 sandy081 marked this as a duplicate of #18233 Dec 4, 2017
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 4, 2017
@vscodebot
Copy link

vscodebot bot commented Dec 4, 2017

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Dec 4, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search-replace Search and replace issues
Projects
None yet
Development

No branches or pull requests

5 participants