Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WelcomeUX] Elements get cut off when resize window #18858

Closed
mousetraps opened this issue Jan 20, 2017 · 8 comments
Closed

[WelcomeUX] Elements get cut off when resize window #18858

mousetraps opened this issue Jan 20, 2017 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@mousetraps
Copy link
Contributor

Testing #18091
See below, where the top of the welcome screen is cut off. Scrolling using mouse wheel also doesn't work.

image

@bgashler1
Copy link
Contributor

@chrmarti it seems we have some custom scroll capability (not standard overflow:scroll-y

Can you tell me how to enable vertical scrolling for this?

@chrmarti
Copy link
Collaborator

It should do that automatically. I think you only need to make sure the outer div grows with the content and doesn't stop at 100%. The reason we're doing something custom made is that we want our custom scrollbars. /cc @joaomoreno

@chrmarti
Copy link
Collaborator

ScrollableElement doesn't work with absolute positioned content. This seems to work better (needs proper selector):

.monaco-workbench > .part.editor > .content .monaco-scrollable-element > div {
  align-items: center;
  display: flex;
  justify-content: center;
}

@joaomoreno
Copy link
Member

@chrmarti If you just want lookalike scrollbars, check the ::-webkit-scrollbar* styles in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/html/browser/webview.ts

@joaomoreno joaomoreno added this to the January 2017 milestone Jan 26, 2017
@joaomoreno
Copy link
Member

I've assigned this to January, move it out if not applicable.

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Jan 26, 2017
@chrmarti
Copy link
Collaborator

@joaomoreno I have already hacked up my own pageUp/Down actions. Should I turn back now? :D

@chrmarti chrmarti added the candidate Issue identified as probable candidate for fixing in the next release label Jan 26, 2017
@joaomoreno
Copy link
Member

@chrmarti Why the candidate tag? It's meant to be used for candidate issues for a recovery build.

@joaomoreno joaomoreno added verified Verification succeeded and removed candidate Issue identified as probable candidate for fixing in the next release labels Jan 27, 2017
@chrmarti
Copy link
Collaborator

@joaomoreno I need to read the instructions again, thought we start adding candidate on Thursday's fixes.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants