Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WelcomeUX] Why is the editor walkthrough background color fixed? #18905

Closed
Tyriar opened this issue Jan 20, 2017 · 2 comments
Closed

[WelcomeUX] Why is the editor walkthrough background color fixed? #18905

Tyriar opened this issue Jan 20, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 20, 2017

Testing #18091

On the red theme is should be a red background:

image

This could make the text look awkward/inconsistent on some themes (which could easily be set on welcome page before going to walkthrough).

@Tyriar
Copy link
Member Author

Tyriar commented Jan 20, 2017

On a related note, shouldn't the preview be the regular workbench color so that proper contrast and colors can be ensured? The same applies to the welcome page:

image

The blue links may also clash with the theme background.

@chrmarti
Copy link
Collaborator

Using CSS for the embedded editor's background. That limits us to one color per base theme. We could instead compute one from the theme's background color.

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Feb 2, 2017
@chrmarti chrmarti added this to the May 2017 milestone May 17, 2017
@Tyriar Tyriar added the verified Verification succeeded label Jun 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants