Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download/install extensions via proxy that enforces SSL #192794

Closed
yannickbt64 opened this issue Sep 11, 2023 · 4 comments
Closed

Download/install extensions via proxy that enforces SSL #192794

yannickbt64 opened this issue Sep 11, 2023 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@yannickbt64
Copy link

yannickbt64 commented Sep 11, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.82
  • OS Version: Windows 10 22H2 Build 19045.3324

Steps to Reproduce:

  1. Try installing any extension from the extension pane
  2. Check output, it shows something like :
    2023-09-11 11:41:06.287 [error] end of central directory record signature not found: CorruptZip: end of central directory record signature not found at w.download (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:92:141) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async B.x (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:92:19757) at async B.h (c:\Program Files\Microsoft VS Code\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:92:17797)

There are a lot of different "ways" reported for using a certificate in Windows.
It is suggested among many issues to set environment variable NODE_EXTRA_CERTS to point to a file, like C:\cert\ca-cert.pem
But this doesn't really work as reported here electron/electron#10257

A suggestion here was to simply disable ssl #155
This isn't an option for me. My corporate proxy enforce SSL with a certificate and it just won't work without it, period.

Yet, I can get to work easily with other "package managers" like Python's "pip" and Anaconda's "conda".
For both of them, all I have to do is provide my proxy HTTP address, and a path to the proxy certificate like "C:\cert\proxy-ca-cert.pem".
I can also make wget work with a wgetrc, providing again the HTTP proxy address, HTTPS address (which is exactly, character for character, the same as the HTTP one, i.e. http://proxy-bla-bla.com:8080), and the certificate path.

Why can't we do this in VSCode? Why not add a "proxy certificate file" field in settings so that we can specify exactly which certificate to use for the proxy connection to work? Right now, I have to download vsix files manually and manually add them.

@vscodenpa
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@plattenschieber
Copy link

@yannickbt64 does this happen 100% due to the proxy cert? We just found out yesterday, that vsix files seem to be downloaded as zip files (which could be due to the proxy throwing away headers for ContentEncoding) containing the vsix file which let's VSCode think it's a CorruptZip error.
And could you confirm your issue is still existent with the newest VSCode version?

@chrmarti
Copy link
Collaborator

chrmarti commented Dec 4, 2023

Please check with the latest Insiders version which contains a fix for #199675: https://code.visualstudio.com/insiders/

@chrmarti chrmarti assigned sandy081 and unassigned chrmarti Dec 4, 2023
@chrmarti chrmarti added the info-needed Issue requires more information from poster label Dec 4, 2023
@microsoft microsoft deleted a comment from vscodenpa Dec 8, 2023
@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

5 participants