Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag, report document selectors that use notebookType and cell-scheme #194122

Open
jrieken opened this issue Sep 26, 2023 · 0 comments
Open

Flag, report document selectors that use notebookType and cell-scheme #194122

jrieken opened this issue Sep 26, 2023 · 0 comments
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. extensions Issues concerning extensions

Comments

@jrieken
Copy link
Member

jrieken commented Sep 26, 2023

Testing #194077

While working on GHINB joh/civic-tahr I was wondering why my code action provider wasn't ever called. Turns out I had the following selector configured

{ scheme: 'vscode-notebook-cell', notebookType: 'github-issues' }

This never matches because the notebook-types makes us use the scheme of the notebook file, not its cells. This behaviour is clearly documented (by me 🙊) but I still missed it... We should be nice and somewhere print a clear warning when this happens

@jrieken jrieken added debt Code quality issues extensions Issues concerning extensions engineering VS Code - Build / issue tracking / etc. labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

2 participants