Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete from suggest voids following characters #204808

Closed
AnrDaemon opened this issue Feb 9, 2024 · 28 comments
Closed

Complete from suggest voids following characters #204808

AnrDaemon opened this issue Feb 9, 2024 · 28 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension info-needed Issue requires more information from poster suggest IntelliSense, Auto Complete

Comments

@AnrDaemon
Copy link

Type: Bug

The #198793 become more and more frequent in my daily work. More often in HTML files, but it started to creep into other type of code.

I've assembled an example workspace to reproduce the issue.

After a number of attempts, I've managed to reproduce it in VS Code without extensions, using only textual suggestions, as hinted by @ecmel in ecmel/vscode-html-css#278 (comment)

VS Code version: Code 1.85.2 (8b37750, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i5-3550 CPU @ 3.30GHz (4 x 3303)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 15.96GB (8.07GB free)
Process Argv
Screen Reader no
VM 0%
@vscodenpa
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@jrieken jrieken added the ~info-needed Issue requires more information from poster (with bot comment) label Feb 9, 2024
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@vscodenpa vscodenpa added info-needed Issue requires more information from poster and removed ~info-needed Issue requires more information from poster (with bot comment) labels Feb 9, 2024
@jrieken
Copy link
Member

jrieken commented Feb 9, 2024

After a number of attempts, I've managed to reproduce it in VS Code without extensions,

How? Please share the exact steps

@AnrDaemon
Copy link
Author

ecmel/vscode-html-css#278 (comment)

Exact steps. With video. And confirmation that's not only me observing this issue.

There's obviously some kind of a race, because if you do it REAL SLOW, the issue is hard to reproduce.

@jrieken
Copy link
Member

jrieken commented Feb 9, 2024

Sorry, I don't know what ecmel is about but it doesn't seem like "just vscode without extensions", so please provide a steps here and a simple copy-paste friendly code sample

@AnrDaemon
Copy link
Author

There's no copy-paste friendly code sample, thus the example archive.
The smaller the sample, the harder it is to trigger condition.
But with a HTML file of 2k lines, it's nearly always happens.
Just extract the archive, open in the Insiders build and repeat the steps in the video

2024-01-27_22-01-05.mp4

vscode-html-css#278.tar.gz

@ecmel
Copy link

ecmel commented Feb 9, 2024

Please check: #198793

@vscodenpa
Copy link

Hey @jrieken, this issue might need further attention.

@AnrDaemon, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@AnrDaemon
Copy link
Author

It become more severe in the latest versions of VS Code. So, awaiting the fix. Eagerly.

Copy link

Hey @jrieken, this issue might need further attention.

@AnrDaemon, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@AnrDaemon
Copy link
Author

It more than exists, it is easily the most encountered issue in daily work with HTML.

@AnrDaemon
Copy link
Author

It is suggested that the behavior could be related to editor.quickSuggestions option.
However, it shows as "modified elsewhere" in my instance of VS Code in both User and Workspace configurations, and there's no mention of it in any of the respective JSON files either.

@AnrDaemon

This comment has been minimized.

@AnrDaemon

This comment has been minimized.

@jonnomk
Copy link

jonnomk commented Oct 8, 2024

This happens to me every day. Searching for a solution.

@matthaliski
Copy link

I'm getting this as well. The first time it happened, it slipped by in a commit, and I found it live on the site. I've been paying close attention ever since.

@jrieken
Copy link
Member

jrieken commented Dec 9, 2024

  • ? What do folks have configured for editor.suggest.insertMode, esp also check if you have a more specific configuration for html.
  • ? When a completion overtypes, what does its detail show (press cmd+/ on a completion)

Image

@jonnomk
Copy link

jonnomk commented Dec 9, 2024

I have 'insert' configured for editor.suggest.insertMode. Here's an example of the issue.

20241209-1623-52.6149592.mp4

@jrieken
Copy link
Member

jrieken commented Dec 9, 2024

I have 'insert' configured for editor.suggest.insertMode.

Did you also explicitly change this for html which has this configured to be replace

Here's an example of the issue.

I believe that you are seeing this issue. But also believe that I don't reproduce this and that I cannot base a fix on a recording, only on reproducible steps.

@jonnomk
Copy link

jonnomk commented Dec 9, 2024

I haven't explicitly changed any settings for HTML. Actually, just to see what happens, I deleted all the settings from my settings.json file and the issue still occurs.

@jrieken
Copy link
Member

jrieken commented Dec 9, 2024

what extensions do you have installed?

@jrieken jrieken added the suggest IntelliSense, Auto Complete label Dec 9, 2024
@jonnomk
Copy link

jonnomk commented Dec 9, 2024

I have:

SonarQube
Angular language service
Angular snippets
cognitive-complexity-show
Docker
Easy LESS
EditorConfig
ESLint
Copilot
Copilot chat
JavaScript (ES) code snippets
Rainbow CSV
Sort JSON objects
Minify

Not too many :)

@jrieken
Copy link
Member

jrieken commented Dec 9, 2024

@jonnomk try without them, use bisect

All extensions execute together on a single nodejs process, so in order to narrow down the possible problematic extension, please try the following:

  • run F1 > Help: Start Extension Bisect
  • (this will restart VS Code with half of your extensions disabled)
  • try to do the steps which reproduce the problem
  • if the problem reproduces, click "This is bad" (this narrows down the problematic extension to the half which was enabled)
  • if the problem does not reproduce, click "Good now" (this narrows down the problematic extension to the half which was disabled)
  • these steps will repeat until the problematic extension is found
initial step final
image image image

@jonnomk
Copy link

jonnomk commented Dec 9, 2024

Hi. That's an interesting tool, but it wasn't able to whittle down the problematic extension, even though during the process the problematic behaviour stopped.

I performed my own little test and can confirm it's the Angular Language Service that causes the issue.

Here's a video of it working as expected with the extension disabled:

20241209-1710-13.5388656.mp4

...and here it is with it enabled:

20241209-1714-02.7726089.mp4

Thanks for your time. Hopefully this helps others.

@jrieken jrieken added the *caused-by-extension Issue identified to be caused by an extension label Dec 11, 2024
Copy link

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@AnrDaemon
Copy link
Author

It can be reproduced without any additional extensions, just not as reliable.
There's clearly a timing issue suggesting a race condition somewhere.

@ecmel
Copy link

ecmel commented Dec 24, 2024

@AnrDaemon I agree, this is not related with any extension as demonstrated on ecmel/vscode-html-css#278

@AnrDaemon
Copy link
Author

More specifically, #198793

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension info-needed Issue requires more information from poster suggest IntelliSense, Auto Complete
Projects
None yet
Development

No branches or pull requests

6 participants