Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test node2 transition work #20779

Closed
2 tasks done
roblourens opened this issue Feb 17, 2017 · 4 comments
Closed
2 tasks done

Test node2 transition work #20779

roblourens opened this issue Feb 17, 2017 · 4 comments

Comments

@roblourens
Copy link
Member

roblourens commented Feb 17, 2017

Testing #19650

Complexity: 2

Previously, users would set the 'type' in their launch config to 'node' or 'node2'. Now we will tell users to use the 'node' type, but pick a debug adapter by setting the 'protocol' field. It can be 'legacy', 'inspector', or 'auto'. 'auto' will detect the version of node on the path, and use 'inspector' if it's Node 6.9 or above. If protocol isn't set, it will default to 'legacy' for this milestone.

Verify that

  • If you set "protocol": "legacy" in your launch config, it picks the legacy adapter (In the debug console, it will show that it's using the --debug flag)
  • If you set "protocol": "inspector" in your launch config, it uses the inspect protocol (you will see the --inspect flag)
  • If you set "protocol": "auto", it will detect the version of node on your path, and use inspect if it's 6.9 or above.
  • If you start node running with the --debug flag, and start an attach config that has "protocol": "auto", it will successfully attach
  • If you start node running with the --inspect flag, and start an attach config that has "protocol": "auto", it will successfully attach
  • There are no snippets for node2
@bpasero
Copy link
Member

bpasero commented Feb 20, 2017

@roblourens should this be set to milestone February?

@roblourens roblourens added this to the February 2017 milestone Feb 21, 2017
@roblourens
Copy link
Member Author

Yes thanks

@weinand
Copy link
Contributor

weinand commented Feb 23, 2017

BTW, we had two test items for the "node2 transition" work. Here is the other: #20991

@roblourens
Copy link
Member Author

roblourens commented Feb 23, 2017

I forgot to mark it "on-testplan", sorry. At least it's very well-tested!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants