Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the onEnter rules inside of the reindent lines command #209938

Open
aiday-mar opened this issue Apr 9, 2024 · 0 comments
Open

Adopt the onEnter rules inside of the reindent lines command #209938

aiday-mar opened this issue Apr 9, 2024 · 0 comments
Assignees
Labels
editor-autoindent Editor auto indentation issues polish Cleanup and polish issue

Comments

@aiday-mar
Copy link
Contributor

This was noticed in the following comment #209863 (comment). When applying the Reindent Lines operations, the onEnter rules are not referred to. As a result, the indentation after applying the Reindent Lines command does not match the indentation when typing the same code from top to bottom.

Since we are using the Reindent Lines code in order to detect cases of failing indentation, if we adopt the onEnter rules now, this could eclipse the indentation issues in our regexes and the code. Hence the onEnter rules should be adopted towards the end of the improvement cycle.

@aiday-mar aiday-mar self-assigned this Apr 9, 2024
@aiday-mar aiday-mar added polish Cleanup and polish issue editor-autoindent Editor auto indentation issues labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-autoindent Editor auto indentation issues polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

1 participant