Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error/warning signal delay - only possible to configure some sounds #213617

Closed
isidorn opened this issue May 28, 2024 · 4 comments
Closed

error/warning signal delay - only possible to configure some sounds #213617

isidorn opened this issue May 28, 2024 · 4 comments
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@isidorn
Copy link
Contributor

isidorn commented May 28, 2024

Testing #213344

For example not possible to configure delay for errorOnLine.
Is there a specific reason why we allow configuration only for "general", "errorOnPosition" and "warningAtPosition".

Also what does "general" mean. Should this be called "all"?

@meganrogge
Copy link
Contributor

We have received feedback that error and warning when typing (IE based on position change, not line change) are the ones that need specific configuration.

all would be confusing IMO because it doesn't apply to error and warning position changes.

@isidorn
Copy link
Contributor Author

isidorn commented May 29, 2024

Ok. Makes sense. So "general" does not apply for error and warning - should it be called "other" maybe?

Feel free to close this issue as designed.

@meganrogge meganrogge added the *as-designed Described behavior is as designed label May 30, 2024
@vscodenpa
Copy link

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@meganrogge
Copy link
Contributor

I think general is a good term because it counters the specific ones we allow configuring separately

@microsoft microsoft locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

3 participants