Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not to escape debuggerPath of pipeTransport in launch.json #22514

Closed
tanaka-takayoshi opened this issue Mar 13, 2017 · 2 comments
Closed

Not to escape debuggerPath of pipeTransport in launch.json #22514

tanaka-takayoshi opened this issue Mar 13, 2017 · 2 comments

Comments

@tanaka-takayoshi
Copy link

  • VSCode Version:
    1.11.0-insider
  • OS Version:
    RHEL 7.3

Steps to Reproduce:

  1. Generate launch.json to set up remote debug configuration.
{
  "version": "0.2.0",
  "configurations": [        
    {
        "name": ".NET Core Docker Remote Attach",
        "type": "coreclr",
        "request": "attach",
        "processId": "21",
        "pipeTransport": {
            "pipeProgram": "docler",
            "pipeArgs": [ "exec", "remotedebug-1-mispn"],
            "debuggerPath": "/opt/app-root/src/clrdbg/clrdbg",
            "pipeCwd": "${workspaceRoot}"
        },
        "sourceFileMap": {
            "/opt/app-root/src": "${workspaceRoot}"
        }
    }
  ]
}
  1. Start debug ".NET Core Docker Remote Attach"

  2. Failed to execute docker command. This is because VS Code escape the debuggerPath with parameters.

"docker" exec remotedebug-1-mispn "/opt/app-root/src/clrdbg/clrdbg --interpreter=mi"

The docker command recognizes "/opt/app-root/src/clrdbg/clrdbg --interpreter=mi" as one file path, then failed. I'm not sure which version, but the previous version (maybe 1.10.x-insider or 1.9.x-insider) VS Code didn't escape with option but not escaped like below.

"docker" exec remotedebug-1-mispn /opt/app-root/src/clrdbg/clrdbg --interpreter=mi

I submitted to StackOverflow as a question. But, I found this issue occurred with not only "oc (OpenShit CLI)" command but also "docker" command. So I decided to submit this issue as a bug.
http://stackoverflow.com/questions/42731558/how-not-to-escape-debuggerpath-of-pipetransport-in-launch-json

This issue prevents me from executing remote debug from VS Code to docker.

@weinand
Copy link
Contributor

weinand commented Mar 13, 2017

@tanaka-takayoshi please file .NET related issues against https://github.com/OmniSharp/omnisharp-vscode/issues

@weinand
Copy link
Contributor

weinand commented Mar 13, 2017

This issue was moved to dotnet/vscode-csharp#1318

@weinand weinand closed this as completed Mar 13, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants