Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet: Improve "Wrap with abbreviation" input description #25441

Closed
joaomoreno opened this issue Apr 26, 2017 · 5 comments
Closed

Emmet: Improve "Wrap with abbreviation" input description #25441

joaomoreno opened this issue Apr 26, 2017 · 5 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
April 2017

Comments

@joaomoreno
Copy link
Member

Testing #25358

image

There should be a short description of what I should provide in that input box. Similar to git clone:

image
@joaomoreno
Copy link
Member Author

Same for Update tag, a better description would simply be Tag name:

image

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Apr 26, 2017
@ramya-rao-a ramya-rao-a added this to the April 2017 milestone Apr 26, 2017
@ramya-rao-a ramya-rao-a added the emmet Emmet related issues label Apr 26, 2017
@ramya-rao-a
Copy link
Contributor

Good point

@ramya-rao-a
Copy link
Contributor

Fixed with microsoft/vscode-emmet-legacy@a16f5bc

@joaomoreno
Copy link
Member Author

Seems fixed, but there's no more Emmet 2.0 actions...

@joaomoreno joaomoreno added the verified Verification succeeded label Apr 28, 2017
@ramya-rao-a
Copy link
Contributor

The below 5 built-in commands are now routed to the emmet extension if the user has the extension installed and enabled. So no more Emmet 2.0 actions.

Emmet: Update Tag
Emmet: Remove Tag
Emmet: Go to Matching Pair
Emmet: Wrap with Abbreviation
Emmet: Expand Abbreviation

This was done so that the existing keybindings for these actions continue to work for the user.
And from the user's perspective, there is no difference in usage.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
2 participants
@joaomoreno @ramya-rao-a