Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find widget covers find result when at the first line #27495

Closed
michelkaporin opened this issue May 30, 2017 · 1 comment
Closed

Find widget covers find result when at the first line #27495

michelkaporin opened this issue May 30, 2017 · 1 comment
Assignees
Labels
editor-find Editor find operations
Milestone

Comments

@michelkaporin
Copy link
Contributor

michelkaporin commented May 30, 2017

Testing #27412:

OS: Windows 10

  1. Open new empty plain text file
  2. Copy paste the following text into it:

Lorem ipsum dolor sit amet, consectetur adipiscing elit.Proin hendrerit orci in dignissim consequat.Integer ultricies nunc eu massa aliquam tristique.Donec nisl ex, imperdiet ut ultricies eget, volutpat eu nisl.Aliquam varius tincidunt sapien, a pretium mi vulputate sit amet.Sed augue sem, feugiat vel dapibus vel, condimentum a augue.Nam fringilla diam vitae turpis pretium ultricies.Nulla ac ornare dui.Curabitur lacinia felis vitae justo rutrum, et sodales risus congue.Integer posuere felis sed ligula sagittis consectetur.Integer condimentum consequat facilisis.

  1. Ctrl+F, search for varius (or any word that is supposed to be under the find widget).
    -> Match is hidden beneath the search widget, although scrolling up reveals it.

I would expect to reveal the match when I hit it, when searching, so that I don't need to scroll back and forth to understand where is the match, if I am a first-time VS Code user.

As a suggestion maybe it is better to do the scrolling the editor up on the user behalf, revealing the search match?

@michelkaporin
Copy link
Contributor Author

Consider also the case when user searches for something, then scrolls to the top to reveal the match, then he closes find widget and suddenly decides to search for the same word again. At this point the search widget appears hovering the match and he needs to scroll again up, which is annoying.

@rebornix rebornix added the editor-find Editor find operations label May 30, 2017
@rebornix rebornix added this to the May 2017 milestone Jun 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-find Editor find operations
Projects
None yet
Development

No branches or pull requests

2 participants