Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find widget does not leave space at the top when navigating between tabs #27515

Closed
michelkaporin opened this issue May 30, 2017 · 2 comments
Closed

Find widget does not leave space at the top when navigating between tabs #27515

michelkaporin opened this issue May 30, 2017 · 2 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations verified Verification succeeded
Milestone
May 2017

Comments

@michelkaporin
Copy link
Contributor

michelkaporin commented May 30, 2017 •
edited
Loading

Testing #27412:

OS: Windows 10

  1. Open new empty plain text file
  2. Copy paste the following text into it:

Lorem ipsum dolor sit amet, consectetur adipiscing elit.Proin hendrerit orci in dignissim consequat.Integer ultricies nunc eu massa aliquam tristique.Donec nisl ex, imperdiet ut ultricies eget, volutpat eu nisl.Aliquam varius tincidunt sapien, a pretium mi vulputate sit amet.Sed augue sem, feugiat vel dapibus vel, condimentum a augue.Nam fringilla diam vitae turpis pretium ultricies.Nulla ac ornare dui.Curabitur lacinia felis vitae justo rutrum, et sodales risus congue.Integer posuere felis sed ligula sagittis consectetur.Integer condimentum consequat facilisis.

  1. Ctrl+F, search for varius (or any word that is supposed to be under the find widget).
    Scrolling up is allowed at this point.
  2. Now navigate to another tab and go back to the plain text file again (without closing the find widget).
  3. Scrolling up is not allowed but once scrolled down, the blank space to scroll to appears at the top again.

We should keep the state when navigating between tabs with opened find widget.
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations labels May 30, 2017
@rebornix
Copy link
Member

rebornix commented Jun 1, 2017

@michaelchiche really good bug, thanks for detailed testing :)

@rebornix rebornix added this to the May 2017 milestone Jun 1, 2017
@michelkaporin
Copy link
Contributor Author

@rebornix thank you 😊

@bpasero bpasero added the verified Verification succeeded label Jun 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations verified Verification succeeded
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
3 participants
@rebornix @bpasero @michelkaporin