Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Smoke Test: prevent VS Code from auto updating #27556

Closed
weinand opened this issue May 30, 2017 · 5 comments
Closed

Automated Smoke Test: prevent VS Code from auto updating #27556

weinand opened this issue May 30, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. smoke-test-failure
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented May 30, 2017

testing #27456:

I was running the Automated Smoke Test with an older version of VS Code.
But I was not seeing the expected improvement because VS Code auto updates itself while running the Automated Smoke Tests.

I suggest to disable the auto updating while running the Automated Smoke Test.

@bpasero
Copy link
Member

bpasero commented May 30, 2017

Today you can only disable auto updates via a setting: update.channel: "none". we might need to introduce another startup flag for this otherwise.

@michelkaporin
Copy link
Contributor

@bpasero exactly, setting update.channel to 'none' in the test for every test case is too time-consuming, so we will need a new flag.

I will leave it as a feature request for now and add it in the next version.

@michelkaporin michelkaporin added the feature-request Request for new features or functionality label May 30, 2017
@michelkaporin michelkaporin added this to the Backlog milestone May 30, 2017
@weinand
Copy link
Contributor Author

weinand commented Jun 2, 2017

Another finding: as long as all the tests succeed, VS Code does not have enough time to download an update. But as soon there is a test failure, the automated tests retry which gives VS Code enough time to download the update (and replace VS Code). The next test of the suite will then be run on the updated (typically older) version.

@michelkaporin michelkaporin added the engineering VS Code - Build / issue tracking / etc. label Jul 11, 2017
@kieferrm kieferrm added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Jul 11, 2017
@kieferrm
Copy link
Member

In order to get a correct picture which tests are failing you need to disable auto-update. One workaround is to patch the product.json in the version that is being smoke-tested.

@joaomoreno
Copy link
Member

This is fixed.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. smoke-test-failure
Projects
None yet
Development

No branches or pull requests

6 participants