Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display icons for navigation group of menus #27654

Closed
rebornix opened this issue May 30, 2017 · 3 comments
Closed

Only display icons for navigation group of menus #27654

rebornix opened this issue May 30, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded

Comments

@rebornix
Copy link
Member

re #27467

For commands in navigation group, right now we'll try to show icons first if they exist. If not, we display the command title. Our builtin explorer title only shows icons, so maybe we should only allow icons to be displayed as well. Allowing text being displayed sometimes looks weird.

screen shot 2017-05-30 at 3 10 55 pm

@sandy081
Copy link
Member

sandy081 commented May 31, 2017

Its a good point. These actions are contributable. Have to see how they are rendered in other locations.

@bpasero What do we do in editor title area?

@sandy081 sandy081 added api tree-views Extension tree view issues labels May 31, 2017
@bpasero
Copy link
Member

bpasero commented May 31, 2017

The SCM viewlet has a similar "issue" where I would like to see an icon and not the text:

image

I think today we are not restricting any extension to force use an icon, in other words labels are allowed if no icon is provided. @jrieken would know for sure if that is true.

@jrieken
Copy link
Member

jrieken commented May 31, 2017

Yes, not restrictions and I'd that's fair. Tho it should not look ugly if no icons are provided, e.g no spacing issues like above.

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug and removed api labels Aug 25, 2017
@sandy081 sandy081 added this to the Backlog milestone Aug 25, 2017
@sandy081 sandy081 modified the milestones: Backlog, September 2018 Sep 14, 2018
@miguelsolorio miguelsolorio added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants