Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second time proposal is selected it is not read in VoiceOver #27655

Closed
chrmarti opened this issue May 30, 2017 · 11 comments · Fixed by #55542
Closed

Second time proposal is selected it is not read in VoiceOver #27655

chrmarti opened this issue May 30, 2017 · 11 comments · Fixed by #55542
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Collaborator

  • VSCode Version: Code - Insiders 1.13.0-insider (afe47dc, 2017-05-30T10:34:18.253Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions: none

Testing #27315

Steps to Reproduce:

  1. Enable VoiceOver
  2. Open content assist
  3. First proposal is selected and read
  4. Close content assist
  5. Open content assist with same proposals
  6. First proposal is selected, but not read
@ramya-rao-a
Copy link
Contributor

Between closing and opening of content assist, does the suggestion list go away or remain?

@chrmarti
Copy link
Collaborator Author

It goes away.

@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels May 31, 2017
@ramya-rao-a ramya-rao-a modified the milestones: May 2017, June 2017 May 31, 2017
@ramya-rao-a
Copy link
Contributor

I also see this for suggestion list items that have already been visited

@ramya-rao-a ramya-rao-a modified the milestones: July 2017, June 2017 Jun 23, 2017
@ramya-rao-a ramya-rao-a added the help wanted Issues identified as good community contribution opportunities label Jul 18, 2017
@ramya-rao-a ramya-rao-a modified the milestones: August 2017, July 2017 Aug 2, 2017
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, August 2017 Aug 29, 2017
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, August 2018 Jul 31, 2018
@JacksonKearl
Copy link
Contributor

It reads it out every other time it shows up. Interesting.

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 3, 2018

I'm still seeing this issue when manually triggering suggestions on 0c2d71e

Steps:

  1. In JS file, trigger suggestions using ctrl+space on a blank line
  2. press esc
  3. Trigger suggestions manually again without moving the cursor

The first selected suggestions iis not read out again when you do this

@mjbvz mjbvz reopened this Aug 3, 2018
@mjbvz mjbvz added the verification-found Issue verification failed label Aug 3, 2018
@isidorn
Copy link
Contributor

isidorn commented Aug 3, 2018

I do not think this is ciritcal, since this was behaving like this for a couple of releases
@JacksonKearl feel free to postpone to August

@JacksonKearl
Copy link
Contributor

@mjbvz unable to replicate with NVDA. Is this Voiceover? Can you check if 1.25.1 is the same?

@JacksonKearl
Copy link
Contributor

Unable to replicate with Voiceover as well. Could you take another look? This is on 4fa62b2

@JacksonKearl
Copy link
Contributor

Note that not reading suggestions when the editor loses then regains focus is a separate bug, tracked at #53719. @sbatten says he was able to verify this bug.

@joaomoreno
Copy link
Member

@JacksonKearl Moving to August

@joaomoreno joaomoreno modified the milestones: July 2018, August 2018 Aug 6, 2018
@JacksonKearl JacksonKearl removed the verification-found Issue verification failed label Aug 14, 2018
@JacksonKearl
Copy link
Contributor

Note to verifiers: this issue is about the alert not being read twice in the same "context". The issue of alerts not being read when code loses focus then regains it is separate and tracked at #53719.

@chrmarti chrmarti added the verified Verification succeeded label Aug 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants