Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal linking not working with styled file links #29072

Closed
lukephills opened this issue Jun 20, 2017 · 2 comments
Closed

Terminal linking not working with styled file links #29072

lukephills opened this issue Jun 20, 2017 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Backlog

Comments

@lukephills
Copy link

lukephills commented Jun 20, 2017 •
edited
Loading

(Use Help > Report Issues to prefill these)

  • VSCode Version: 1.13.1
  • OS Version: osx 10.11.6

Steps to Reproduce:

  1. Use webpack or at-loader to print some errors in the terminal
  2. Cmd + click on a file name

They aren't recognised as links, perhaps it could be that they're styled? I think it was working in the April version.

screen shot 2017-06-20 at 13 01 24
@Tyriar
Copy link
Member

Tyriar commented Jun 20, 2017 •
edited
Loading

Upstream issue: xtermjs/xterm.js#726

Related issue that will also be needed to fix this: xtermjs/xterm.js#654

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed new release labels Jun 20, 2017
@Tyriar Tyriar added this to the Backlog milestone Jun 20, 2017
@Tyriar Tyriar mentioned this issue Jun 23, 2017
Closed
@Tyriar
Copy link
Member

Tyriar commented Dec 23, 2017

Should be fixed now

@Tyriar Tyriar closed this as completed Dec 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Tyriar @lukephills