Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] HTML tags in Typescript comment #29188

Closed
bingzheyuan opened this issue Jun 21, 2017 · 6 comments
Closed

[Feature] HTML tags in Typescript comment #29188

bingzheyuan opened this issue Jun 21, 2017 · 6 comments
Assignees
Labels
*as-designed Described behavior is as designed *duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster

Comments

@bingzheyuan
Copy link

bingzheyuan commented Jun 21, 2017

For the following code snippet, if cursor is on constructor, you can find the comment shows the HTML tag as well. It will be much better that HTML content can be parsed and ommits the tag in the hover window.

export class Test {
    /**
     * <p>some html tag</p>
     * 
     * @param s some parameter
     */
    constructor(s:string) {

    }
}
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 21, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 21, 2017

We're tracking support for markdown in intellisense with #11877 / #1920

Are there any cases where you need full html supported instead of markdown (with html disabled)? Is html content supported by other jsdoc tools or is html commonly used in codebases?

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Jun 21, 2017
@bingzheyuan
Copy link
Author

I am checking other third party code and I don't know how their code are generated nor any other tools that can properly show the content. Take this code for example https://github.com/CreateJS/EaselJS/blob/master/src/easeljs/display/Graphics.js

@mjbvz mjbvz added the *as-designed Described behavior is as designed label Jun 30, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 30, 2017

Thanks. I'm not in favor of enabling html inside of jsdocs intellisense since markdown is a better solution in most cases. Closing in favor of #11877 / #1920

@mjbvz mjbvz closed this as completed Jun 30, 2017
@bingzheyuan
Copy link
Author

Well, I agree for most cases. What about enable syntax highlight for @XXX keywords in intellisence.

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 3, 2017

@bingzheyuan Which keywords are you not seeing highlighted?

@bingzheyuan
Copy link
Author

bingzheyuan commented Jul 4, 2017

Please check this screenshot. https://code.visualstudio.com/images/angular_decorator-hover.png
Those @xxx keywrods are not typical, but you can find all of them are not highlighted at all. Perhaps we just need to highlight some regular keywods, @params, @return etc, since they are pretty common in comments.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed *duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants