Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the Misuse of the Pointing Hand Cursor #29376

Closed
wangweixuan opened this issue Jun 24, 2017 · 6 comments
Closed

Stop the Misuse of the Pointing Hand Cursor #29376

wangweixuan opened this issue Jun 24, 2017 · 6 comments
Assignees
Labels
*as-designed Described behavior is as designed under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@wangweixuan
Copy link

The UI of Code always gives me a uncomfortable feeling. I finally realized this is because of the faulty cursor.
All the buttons, as well as the tabs and the list items, use the pointing hand cursor, which shouldn't be used. A guideline of Windows states that this cursor is used for text and graphics links because of their weak affordance. Another one recommends us to use hover effects for clickable elements instead (currently we have hover effects for list items and some of the buttons, but not for tabs). It's the same for other platforms.
I hope we can change them into the default arrow cursor and get a fix on this soon.

@vscodebot vscodebot bot added the bug Issue identified by VS Code Team member as probable bug label Jun 24, 2017
@bpasero
Copy link
Member

bpasero commented Jun 26, 2017

@stevencl should we stop using the hand cursor on all platforms maybe?

@bpasero bpasero added ux User experience issues under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug labels Jun 26, 2017
@bpasero bpasero self-assigned this Jun 26, 2017
@bpasero bpasero added this to the Backlog milestone Jun 26, 2017
@bpasero bpasero added the feature-request Request for new features or functionality label Jun 26, 2017
@laibulle
Copy link

laibulle commented Aug 2, 2017

Hi, I totally agree with @wangweixuan.

I use vscode every days and features are really awesome but this hand cursor make Vscode feels like IE5.

I removed hand cursor in this fork to test the behavior. In my opinion it is better but it is a matter of taste.

Do you think it is possible to make it customizable in the settings ?

@stevencl
Copy link
Member

stevencl commented Aug 9, 2017

This makes sense to me too.

@bpasero bpasero removed their assignment Aug 13, 2017
@bpasero bpasero changed the title Enhancement: Stop the Misuse of the Pointing Hand Cursor Stop the Misuse of the Pointing Hand Cursor Nov 16, 2017
@bpasero bpasero removed feature-request Request for new features or functionality workbench labels Nov 16, 2017
@roblourens
Copy link
Member

@bpasero please assign to the right person if not you

@bpasero
Copy link
Member

bpasero commented Nov 17, 2017

Closing "as designed", I see no issues with what we are doing.

@bpasero bpasero closed this as completed Nov 17, 2017
@bpasero bpasero added the *as-designed Described behavior is as designed label Nov 17, 2017
@koggdal
Copy link

koggdal commented Dec 14, 2017

@bpasero Hi, could you elaborate on this? I agree with the rest here, and @wangweixuan backed it up with guidelines for various platforms.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

6 participants