Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal crops wide character #34138

Closed
joaomoreno opened this issue Sep 11, 2017 · 2 comments
Closed

Terminal crops wide character #34138

joaomoreno opened this issue Sep 11, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Sep 11, 2017

My PS1 starts with (one arrow and one space). The space is there so there's enough space to render the arrow. But the new canvas terminal simply crops the arrow.

image

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Sep 11, 2017
@Tyriar Tyriar added this to the September 2017 milestone Sep 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2017

Apparently this is a particularly popular wide character (dupe in #34121), "wide" characters that take up single widths are now cropped as characters own only their cell(s). This arrow char is similar to an emoji, wherein it is a single width character followed by a space. Maybe it should be special-cased and treated like an emoji until a proper solution is devised, due to its popularity (default oh-my-zsh?).

Related: xtermjs/xterm.js#942

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 11, 2017
@Tyriar Tyriar closed this as completed in 6d133f9 Sep 13, 2017
@mjbvz mjbvz added the verified Verification succeeded label Sep 27, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 27, 2017

Ran into #35102 on verification but the problem with the arrow character and other wide characters seems fixed

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants