Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal.integrated.fontLigatures is missing from the most recent insiders builds #35239

Closed
flipphillips opened this issue Sep 27, 2017 · 2 comments
Closed

terminal.integrated.fontLigatures is missing from the most recent insiders builds #35239

flipphillips opened this issue Sep 27, 2017 · 2 comments
Assignees
@Tyriar
Labels
*as-designed Described behavior is as designed terminal General terminal issues that don't fall under another label

Comments

@flipphillips
Copy link

  • VSCode Version: Version 1.17.0-insider (1.17.0-insider)
  • OS Version: macOS 10.13

Steps to Reproduce:

  1. Open User Settings
  2. Notice that "terminal.integrated.fontLigatures": true, now has the squiggle of 'this is not an option' under it.
  3. Confirm looking in master preferences

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Sep 27, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2017

This was intentional to support to big performance improvement in latest. You can read more about it here xtermjs/xterm.js#938

Issue to support it again: xtermjs/xterm.js#958

@Tyriar Tyriar closed this as completed Sep 27, 2017
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Sep 27, 2017
@flipphillips
Copy link
Author

OK- makes sense / understandable. I'm all for optimizing render'n.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flipphillips @Tyriar