Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find in terminal highlight is off after emojis #37440

Closed
roblourens opened this issue Nov 1, 2017 · 2 comments
Closed

Find in terminal highlight is off after emojis #37440

roblourens opened this issue Nov 1, 2017 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities l10n-platform Localization platform issues (not wrong translations) terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
June 2018

Comments

@roblourens
Copy link
Member

image
@roblourens roblourens added the terminal General terminal issues that don't fall under another label label Nov 1, 2017
@roblourens roblourens mentioned this issue Nov 1, 2017
Closed
@Tyriar Tyriar mentioned this issue Nov 2, 2017
Closed
@Tyriar
Copy link
Member

Tyriar commented Nov 2, 2017

Upstream issue: xtermjs/xterm.js#1103

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 2, 2017
@Tyriar Tyriar added this to the Backlog milestone Nov 2, 2017
@Tyriar Tyriar mentioned this issue Dec 28, 2017
Closed
@Tyriar Tyriar added the l10n-platform Localization platform issues (not wrong translations) label Dec 28, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2018

Seems fine now, tested on macOS:

screen shot 2018-06-21 at 3 45 24 pm

@Tyriar Tyriar closed this as completed Jun 21, 2018
@Tyriar Tyriar modified the milestones: Backlog, June 2018 Jun 21, 2018
@mjbvz mjbvz added the verified Verification succeeded label Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities l10n-platform Localization platform issues (not wrong translations) terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
3 participants
@roblourens @Tyriar @mjbvz