Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal slow zoom even when it is not visible #38811

Closed
mjbvz opened this issue Nov 20, 2017 · 4 comments
Closed

Terminal slow zoom even when it is not visible #38811

mjbvz opened this issue Nov 20, 2017 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug perf terminal General terminal issues that don't fall under another label
Milestone
Backlog

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 20, 2017 •
edited
Loading

Steps to Reproduce:

  1. Open vs code
  2. Open terminal
  3. Switch to a different panel, such as output
  4. Zoom in using cmd +

Issue
The terminal takes ~200ms to rebuild the character atlas, even though it is not currently visible:

screen shot 2017-11-20 at 10 50 54 am

Also happens if the output panel has been hidden
@mjbvz mjbvz added terminal General terminal issues that don't fall under another label perf labels Nov 20, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 14, 2017

Once we move to Chrome 61 we will be able to move this to another thread. For start up this is more of an important issue and is tracked in #40025

@Tyriar Tyriar added this to the Backlog milestone Dec 14, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 14, 2017

Upstream issue to move into a worker xtermjs/xterm.js#955

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jan 2, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2018

A workaround for this may be to use this experimental setting:

"terminal.integrated.experimentalTextureCachingStrategy": "dynamic"

@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2018

dynamic is now the default, I think this is fixed now.

@Tyriar Tyriar closed this as completed Sep 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug perf terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Tyriar @mjbvz