Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing doesn't work for medium sized projects on Windows 10 (files don't show up in 'Search in file' and 'Go to file') #40076

Closed
SqueezeToyAliens opened this issue Dec 12, 2017 · 18 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@SqueezeToyAliens
Copy link

SqueezeToyAliens commented Dec 12, 2017

  • VSCode Version: 1.18.1
  • OS Version: Windows 10 Home Edition (64 bit)

Hi guys,

I have a problem with indexing for both my web(default support) and Python(with the official Python extension installed) projects (22k files & 30k files projects). For some of those(web projects) VSCode works fine but for the others I can't find any files in Go to file and Search in files, excluding those I already opened with the editor.

I deleted any cache/settings both for my user and folder and even uninstalled(then re-installed) VSCode but it still occurs in the same projects. I tried the Insiders build(1.19.0-insider) and it doesn't seem to be solved(yet) there. In addition, I double verified my user and folder "search.exclude" and "files.exclude" settings.

NOTE: I originally commented here(requested to open a new issue):

#39440 (comment)

It seems to be the exact same problem, but for medium sized projects

Steps to Reproduce:

  1. Open the problematic project

Reproduces without extensions: Yes

Thanks in advance,
Elran

@vscodebot vscodebot bot added the search Search widget and operation issues label Dec 12, 2017
@SqueezeToyAliens SqueezeToyAliens changed the title Indexing doesn't work for medium sized projects on Windows 10 (files don't show up in Search on file and Go to file) Indexing doesn't work for medium sized projects on Windows 10 (files don't show up in 'Search in file' and 'Go to file') Dec 12, 2017
@ghost
Copy link

ghost commented Dec 12, 2017

Hi, try to add this to your settings: "files.useExperimentalFileWatcher": true

Try to exclude as much as possible stuff like tmp, temp, dist, build, node_modules, bower_components, etc. all stuff which is not needed for you in search/go to file, they still will be available in file explorer.

Check if "search.useRipgrep" is true.

Add these settings too:

"search.useIgnoreFilesByDefault": true,
"search.useIgnoreFiles": true

@SqueezeToyAliens
Copy link
Author

SqueezeToyAliens commented Dec 12, 2017

Hi, thanks very much for the help. It works now! @bsvipas

What made it work was to set the property "search.useRipgrep" to false. Or more accurately, what made the bug was the use of Ripgrep on Windows 10.

If you have the time for an optional question (I always have to know the whys and hows):
Except for the expected impact on performance, is there any other implication of setting this property to false? because I can't find any documentation on that.

@roblourens
Copy link
Member

Thanks for trying that, I'd rather get to the bottom of why it doesn't work with ripgrep, if you don't mind a little more trouble shooting.

  • In a folder where it doesn't work, can you show the output of the search output pane?

image

  • What's different between the folders where it works, and where it doesn't?

@SqueezeToyAliens
Copy link
Author

image

So to the point. That's the output for the folders where it doesn't work (and ripgrep is enabled, by default). There is no output when/for:

  • a project where the indexing worked initially
  • ripgrep is disabled

Because of that 'access denied' message, I thought it might worth the effort to try and run VSCode as an administrator, just in case.. but it didn't change anything.

Hope it helps! @roblourens

@roblourens
Copy link
Member

Is that folder tracked in OneDrive?

@SqueezeToyAliens
Copy link
Author

SqueezeToyAliens commented Dec 12, 2017

Nope. I'd used to sync my workspace with OneDrive a few months ago(it was stored in a different location, 'elran/OneDrive/Workspace'), but I already learned this lesson ;)

@roblourens
Copy link
Member

Hm... so what's different about that location? Is it all folders under Workspace that don't work?

@SqueezeToyAliens
Copy link
Author

SqueezeToyAliens commented Dec 13, 2017

Nope, some of them work and others don't. Though I only checked this for 4 folders (didn't work for 2 till I disabled ripgrep).

@roblourens
Copy link
Member

I wonder if you copied that folder out of OneDrive earlier and it brought some weird attributes along with it?

@SqueezeToyAliens
Copy link
Author

SqueezeToyAliens commented Dec 13, 2017

I copied the problematic folders out of OneDrive. Concerning your question.. I didn't notice anything on git, so I don't think so, but the only think certain in this world is uncertainty :)

If you heard about similar cases with folders that carry some evil out of OneDrive I'll be happy to know what should I look for(also touches the rest of the trauma victims)
@roblourens

@roblourens
Copy link
Member

Well there is a bug around searching in some OneDrive folders - #35433, and it's suspicious that you get exactly the same symptoms and error message - (os error 5).

Is it possible to try re-cloning the project into a different location? OneDrive can use special filesystem nodes which don't really show up anywhere else.

@PixelT
Copy link

PixelT commented Dec 15, 2017

I have the same issues as author have in main topic (+ this one: #39440), but on MacOS
I have project with magento2 + couple of themes and the quick open option doesn't work for me (#40272)

When I set "search.useRipgrep": false in my settings the quick open work properly, but it is the proper way to "fix" this issue?

Update https://github.com/BurntSushi/ripgrep doesn't help

@Srekel
Copy link

Srekel commented Dec 18, 2017

Same issue here, disabling ripgrep seems to work.

  • VSCode Version: Code 1.19.0 (816be67, 2017-12-14T12:06:43.492Z)
  • OS Version: Windows_NT x64 10.0.16299

@PixelT
Copy link

PixelT commented Dec 18, 2017

Unfortunatelly it stop works for me even if I have "search.useRipgrep": false ....

@roblourens
Copy link
Member

@PixelT I asked you a question about your problem in #40272 earlier

@SqueezeToyAliens
Copy link
Author

SqueezeToyAliens commented Dec 27, 2017

Hi, sorry for the late response.

These are the steps that solved the issue for me:

I cloned the project(s) folder again from the remote repo.

I guess you were right, @roblourens , "OneDrive can use special filesystem nodes which don't really show up anywhere else.". Yes, it does and this is why(I guess) it didn't work for me even though I moved out those folders from my One-Drive and why I didn't notice any change in my local git repo.

Thanks for the kind help, hope it will help others.

@arturolinares
Copy link

I'm having this issue in OSX with a big Drupal project (php). Disabling ripGrep fixed it.

@roblourens
Copy link
Member

Thanks for following up @ElranKadosh. I will file this under #35433 - it's surprising that the onedrive strangeness persists even when the folder isn't tracked by onedrive anymore.

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

5 participants