Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting an extension does not give immediate user feedback #4146

Closed
isidorn opened this issue Mar 14, 2016 · 8 comments
Closed

Deleting an extension does not give immediate user feedback #4146

isidorn opened this issue Mar 14, 2016 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2016

Related to #4024

  • VSCode Version: 18ebb4a
  • OS Version: Linux

Steps to Reproduce:

  1. Open VSCode, install an extension
  2. quick open > show installed extensions > click on the delete button to uninstall the extension
  3. I do not get any feedback and quick open stays open, I only get notifications once I manually close the quick open
  4. I would expect quick open gets closed once I click on uninstall and that I see notifications once the extension gets uninstalled
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Mar 14, 2016
@joaomoreno
Copy link
Member

You know there is no notifications while quick open is open.

Closing as won't fix, cause I wanna move away from quick open.

@isidorn
Copy link
Contributor Author

isidorn commented Mar 14, 2016

I am just saying that action should just close quick open, this way the experience is not very nice.

@joaomoreno
Copy link
Member

It is in its current state because others feel that it shouldn't close, since you might want to uninstall other extensions. I got a bug and made it this way. Not gonna revert.

@isidorn
Copy link
Contributor Author

isidorn commented Mar 14, 2016

Ok, just my 2 cents that the current uninstall experience is bad and making it work for the most common case is more important (uninstalling one extension).
If a user wants to uninstall multiple extensions he can open quick open multiple times, he has more work to do but nothing feels broken. The current state with no uninstall feedback feels broken, especially now that we have introduced install feedback.

@joaomoreno
Copy link
Member

Ok. Should it also close when clicking the visually identical install action?

@isidorn
Copy link
Contributor Author

isidorn commented Mar 14, 2016

No, since for that I get feedback both in the quick open icon and in the status bar icon. And the scenario to install multiple extensions is higher likely to happen then to uninstall multiple imho.

Maybe the delete icon could also provide feedback like the install icon in quick open.

@joaomoreno
Copy link
Member

I'd just get a bug that the two actions look alike but behave differently.

And the uninstall icon also provides feedback, it turn itself into the install one..

bug

@isidorn
Copy link
Contributor Author

isidorn commented Mar 14, 2016

Ok, makes sense, I just created this one that would improve this experience a bit I think
#4165

@isidorn isidorn added the verified Verification succeeded label Mar 18, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants