Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to disable?: 'Save as Workspace?' prompt, upon closing a window #42657

Closed
DavidLudwig opened this issue Jan 31, 2018 · 3 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) workbench-multiroot Multi-root (multiple folders) issues

Comments

@DavidLudwig
Copy link

Using the latest, released version of VSCode, at the time of this writing (2018-Jan-31; version 1.19.3), on MacOS High Sierra (and last tested on 10.13.2), and with extensions disabled, I see the following behavior, which, in some cases, can be unnecessarily time-consuming:

Attempting to close a window that has files open from multiple, disparate directories, the following prompt always appears:

"Do you want to save your workspace configuration as a file?"

A set of buttons (with "Don't Save", "Cancel", "Save") is also presented, offering options. One of the dialogs buttons must be selected, in order to close the window.

Screenshot:

vscode

This prompt does not come up when trying to close a window that is associated with a single file, or a single directory.

Here is an example of how to launch VSCode from an OS' command shell, to reproduce this prompt:

code -n --disable-extensions DirectoryA DirectoryB

Is there a way to disable this prompt via setting(s) in VSCode? If not, much such a feature be feasible?

@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Feb 1, 2018
@bpasero
Copy link
Member

bpasero commented Feb 1, 2018

#30972 and #30974

@bpasero bpasero closed this as completed Feb 1, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 1, 2018
@DavidLudwig
Copy link
Author

I am interested in discussing the possibility of adding a user-configurable setting that would alter this behavior. If it were set, closing a new, unnamed and unsaved workspace could, effectively, choose the "Don't Save" option.

I am unsure which of the aforementioned issues, #30972 or #30974, would be appropriate to make this suggestion, if any. #30974 looks a bit closer, but I am uncertain.

If you have a moment: do you have any suggestions on where, exactly, to continue discussion of this? I am guessing that limiting discussion to one, and only one of those cases (or some other one!), would be best.

@DavidLudwig
Copy link
Author

Additionally,

I would be willing to try providing a candidate pull request for this, then iterate on such according to feedback, if it would help.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

2 participants