[css] Redundant css suggestion for color

[ramya-rao-a]

• VSCode Version: Any
• OS Version: Any

Steps to Reproduce:

1. Use the below content and trigger suggestions at the end of the property value

.foo {
   color: #123
}

2. The suggestion list has 2 entries. 1 from emmet, and the other from the css extension repeating the value that is already typed.

Does this issue occur when all extensions are disabled?: Yes

[praveenpuglia]

Is this part of the css-language-service?

[aeschli]

@praveenpuglia Yes, but it's ok to have the issue here.

[octref]

@ramya-rao-a What are you asking for?
Suggesting #123 is working as expected from css. If you want exact match to come before others there are issue for it but I can't find.

[ramya-rao-a]

@octref My question was around why is the exact match even suggested in the first place, it doesnt add any value. I tried the same in other languages. Looks like this is an issue with the filtering logic in the suggestions in VS Code.

When I was trying to integrate emmet in the css extension, this issue was more pronounced as numbers were trigger characters. We can close this issue as we no longer have the integration and also because this is not due to the css extension, but is due to the filtering

[octref]

@ramya-rao-a Well just found out I was the guy that opened the exact issue: #21362

[aeschli]

IMO @ramya-rao-a's request is valid here.
If there's a known set of values for a css property, e.g. for display, we should show each value as a proposal regardless of what is already typed.
But, In this case, we guessed possible values by looking at other locations. When doing that we should ignore the current value. But, if some other location has that value as well, then it makes sense to show the color value.