Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support callstack with more than 20 stack frames #4435

Closed
faxue-msft opened this issue Mar 18, 2016 · 2 comments
Closed

Support callstack with more than 20 stack frames #4435

faxue-msft opened this issue Mar 18, 2016 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@faxue-msft
Copy link

  • VSCode Version: 0.10.11
  • OS Version: Ubuntu 14.04, Window 10

In threads window, currently the depth/level of call stack is hard code limited to 20 frames in debugModel.ts, when there is a deeper call stack the threads window doesn't indicate there are more frames avaiable which is a confusing experience. Please consider:

  1. Add some message on UI indicating there are more stack frames available
  2. Make the stack depth limitation configurable by debugAdpater
@weinand weinand assigned isidorn and unassigned weinand Mar 18, 2016
@weinand
Copy link
Contributor

weinand commented Mar 18, 2016

Yes, we should indicate that there are more stack frames available (requires an addition to the debug protocol), and we need "debug settings" (like 'max number of stack frames') that apply to the the frontend.

@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 19, 2016
@isidorn isidorn added this to the Backlog milestone Mar 19, 2016
@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2016

This has been fixed as part of #4792

@isidorn isidorn closed this as completed Mar 31, 2016
@isidorn isidorn added the verified Verification succeeded label Apr 22, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants