Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Organize Imports is now a code action #48150

Closed
2 tasks done
mjbvz opened this issue Apr 18, 2018 · 0 comments
Closed
2 tasks done

Test: Organize Imports is now a code action #48150

mjbvz opened this issue Apr 18, 2018 · 0 comments

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 18, 2018

Complexity: 2

Test for #47845 and #46647

Overview
The JS/TS organize imports action was changed from being a command to being a code action

Testing

  • Open a ts file with unordered imports.

    • Check that organize imports shows in command palette and performs the correct action.
    • Check that the keybinding for organize imports: option+shift+o is functional
  • Open a non-ts/js file

    • Check that no organize imports action is in the command palette and that the keybinding has no effect (or that it performs its standard action).
  • Now install TS 2.7 in a workspace: npm install [email protected] and use this as your workspace version

    • Back in a ts file, check that organize imports does not show up again
@mjbvz mjbvz added this to the April 2018 milestone Apr 18, 2018
@joaomoreno joaomoreno removed their assignment Apr 24, 2018
@roblourens roblourens removed their assignment Apr 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants