Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow clearing search viewlet when no results present #48360

Closed
roblourens opened this issue Apr 22, 2018 · 0 comments
Closed

Allow clearing search viewlet when no results present #48360

roblourens opened this issue Apr 22, 2018 · 0 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
April 2018

Comments

@roblourens
Copy link
Member

roblourens commented Apr 22, 2018 •
edited
Loading

Fixed by #48324

For the clear button it shouldn't matter whether there are
search results found or not. The clear button gets now enabled
after every search.
@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Apr 22, 2018
@roblourens roblourens added this to the April 2018 milestone Apr 22, 2018
@roblourens roblourens self-assigned this Apr 22, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Apr 23, 2018
@sandy081 sandy081 added the verified Verification succeeded label Apr 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@roblourens @sandy081