Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code becomes unresponsive for silly searches #50676

Closed
weinand opened this issue May 29, 2018 · 1 comment
Closed

VS Code becomes unresponsive for silly searches #50676

weinand opened this issue May 29, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented May 29, 2018

Testing #50498:

  • open vscode workspace with VS Code
  • search for 'e'

Observe:
VS Code becomes unresponsive and the cancel button appears very late (if at all), so there is almost no chance to cancel a search.

@roblourens
Copy link
Member

Yes, with the original search, the frontend gets complete FileMatches. With the new one, it gets a stream of individual matches which have to be merged into FileMatches. The way I do this right now is inefficient and we spend a ton of time there...

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels May 29, 2018
@roblourens roblourens added this to the June 2018 milestone May 29, 2018
@roblourens roblourens modified the milestones: June 2018, July 2018 Jun 28, 2018
@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants