Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Imports not working with npm linked modules #52022

Closed
abhirathore2006 opened this issue Jun 15, 2018 · 3 comments
Closed

Update Imports not working with npm linked modules #52022

abhirathore2006 opened this issue Jun 15, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@abhirathore2006
Copy link

When copying a file, it prompts for Update Imports on clicking yes it is updating npm linked module to something like this

import { fillModelValue, PhotosModel } from '../../../../../../../../mmf-ui-common/dist/lib';

Should be

import { fillModelValue, PhotosModel } from 'mmf-ui-common';

Also it applied same across all the files,which should not happen automatically

  • VSCode Version: 1.25.0
  • OS Version: Ubuntu
@vscodebot
Copy link

vscodebot bot commented Jun 15, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@thomasmichaelwallace
Copy link

thomasmichaelwallace commented Jun 17, 2018

I'm seeing something very similar now that #51970 is fixed for me:

VS Code version: Code - Insiders 1.25.0-insider (7dc9539, 2018-06-15T05:12:05.222Z)
OS version: Darwin x64 17.6.0
Typescript: Version 3.0.0-dev.20180616 (current @next)

import { expect } from 'chai'

is becoming

import { expect } from 'node_modules/@types/chai/index';

after rename.

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 18, 2018

Opened microsoft/TypeScript#25059 to track this upstream

@mjbvz mjbvz closed this as completed Jun 18, 2018
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jun 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants