WorkspaceEdit should have an option to adjust whitespaces (like snippets)

[yaohaizh]

CodeAction and CompletionItems result doesn't format according to current selected opened file.
Code snippets (like ctor) are indented with tabs, but vscode fixes the indentation on-the-fly, according to its preferences. And the codeaction doesn't pass the current editor's indentation setting when invoke codeaction/completions.

Snippet/CodeAction/Completion should have similar behavior.

[jrieken]

We could do this but only when the code action use an edit, not a command. @yaohaizh Can you provide a concrete sample please.

[MeikTranel]

@jrieken Given a workspace with everything set to indent using 2 spaces:

{
    "editor.insertSpaces": true,
    "editor.tabSize": 2
}

When applying a code action like ctor in a well-formatted (as in formatted according to the given settings) document, the inserted code block is not automatically formatted to the standards of the document. In my particular example, vscode-java was producing tab-indented snippets.

I assume what @yaohaizh meant was that as an API consumer he wants to read the language agnostic formatting settings like editor.tabSize to produce compliant strings beforehand instead of relying on forced formatting to happen after the fact. Is that a correct assessment, @yaohaizh ?

[yaohaizh]

Yes, we use the Command for codeaction, but not edit.

I have uploaded a java sample project for this.
Repro:

1. Install VSCode Java extension
2. Open the project, waiting for the language server to be ready with installation of maven dependencies.
3. Open the Inherit.java file
4. Choose the Inherit class name, trigger the codeaction for "Add unimplemented method" and invoke it, the generated is tab based.
   vscode-java-demo.zip

[jrieken]

Yes, we use the Command for codeaction, but not edit.

What command? Is your extension implementing that? Does it use the WorkspaceEdit-api?

[yaohaizh]

The Command object of LSP for CodeAction result.

Command

Represents a reference to a command. Provides a title which will be used to represent a command in the UI. Commands are identified by a string identifier. The protocol currently doesn’t specify a set of well-known commands. So executing a command requires some tool extension code.

interface Command {
	/**
	 * Title of the command, like `save`.
	 */
	title: string;
	/**
	 * The identifier of the actual command handler.
	 */
	command: string;
	/**
	 * Arguments that the command handler should be
	 * invoked with.
	 */
	arguments?: any[];
}

And this is the java implementation:
https://github.com/eclipse/lsp4j/blob/83ae40a1d4b2b7076a8bb8ea28a953cf1fb1ca84/org.eclipse.lsp4j/src/main/xtend-gen/org/eclipse/lsp4j/Command.java#L44

We put the WorkspaceEdit object in the arguments array.

[jrieken]

We put the WorkspaceEdit object in the arguments array.

Ok, so the WorkspaceEdit describes the textual changes you are making. I will update the title accordingly.

[jdneo]

Hi @jrieken,

May I ask is there any further plan about this issue?

[vscodebot]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodebot]

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

[vscodebot]

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

[vscodebot]

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!